Issue 960353003: cleanup: js_codegen now returns a js_ast.Program

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 960353003: cleanup: js_codegen now returns a js_ast.Program (Closed)

Created:
5 years, 9 months ago by Jennifer Messerly

Modified:
5 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
dev-compiler+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dev_compiler.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

cleanup: js_codegen now returns a js_ast.Program For some reason we were emitting a Block and then doing extra work to avoid emitting the braces. Program handles this already. R=sigmund@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/c717d6f00528a9631775f1b5dd9a037d71e8f008

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -20 lines)			Patch
	M	lib/src/codegen/js_codegen.dart	View		4 chunks	+13 lines, -19 lines	0 comments	Download
	M	lib/src/js/nodes.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Jennifer Messerly

5 years, 9 months ago (2015-03-05 00:52:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c717d6f00528a9631775f1b5dd9a037d71e8f008 (presubmit successful).