Source/core/editing/EditingStyle.cpp - Issue 960353002: Handle null baseStyle in getPropertiesNotIn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/EditingStyle.cpp

Issue 960353002: Handle null baseStyle in getPropertiesNotIn (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/EditingStyle.cpp

diff --git a/Source/core/editing/EditingStyle.cpp b/Source/core/editing/EditingStyle.cpp

index 6e44f9af1d6196af24e7f72b7bed299f42c75d18..7cdae5029f6261cb93ad38b5f97da70c6f907029 100644

--- a/Source/core/editing/EditingStyle.cpp

+++ b/Source/core/editing/EditingStyle.cpp

@@ -1428,9 +1428,13 @@ StyleChange::StyleChange(EditingStyle* style, const Position& position)

if (!style || !style->style() || !document || !document->frame())

return;

+ if (!position.element())

yosin_UTC9 2015/03/11 01:07:32 nit: we can put this test into L1428.

rwlbuis 2015/03/11 19:19:17 Done.

+ return;

RefPtrWillBeRawPtr<CSSComputedStyleDeclaration> computedStyle = position.computedStyle();

// FIXME: take care of background-color in effect

RefPtrWillBeRawPtr<MutableStylePropertySet> mutableStyle = getPropertiesNotIn(style->style(), computedStyle.get());

+ ASSERT(mutableStyle);

reconcileTextDecorationProperties(mutableStyle.get());

if (!document->frame()->editor().shouldStyleWithCSS())