LayoutTests/editing/style/justify-left-crash.html - Issue 960353002: Handle null baseStyle in getPropertiesNotIn

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/style/justify-left-crash.html

Issue 960353002: Handle null baseStyle in getPropertiesNotIn (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address review comments Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html hidden>
	yosin_UTC9 2015/03/11 01:07:31 How about removing "hidden" attribute after execut How about removing "hidden" attribute after executing "jusifyLeft" command? This test script intents to check not to be crashed after "justifyLeft". Once, we executed "justifyLeft", we can change HTML document what we want. rwlbuis 2015/03/11 19:19:17 Clever! I did that in my latest patch set. Show quoted text On 2015/03/11 01:07:31, Yosi_UTC9 wrote: > How about removing "hidden" attribute after executing "jusifyLeft" command? This > test script intents to check not to be crashed after "justifyLeft". Once, we > executed "justifyLeft", we can change HTML document what we want. Clever! I did that in my latest patch set.
	3 <head>

	4 <style>

	5 html, head, style {

	6 display: block;

	7 }

	8 </style>

	9 </head>

	10 <script>

	11 document.designMode = 'on';

	12 document.execCommand("selectAll");

	13 document.execCommand("italic");

	14 document.execCommand("justifyLeft");

	15 </script>

	16 </html>

OLD	NEW