LayoutTests/editing/style/justify-left-crash.html - Issue 960353002: Handle null baseStyle in getPropertiesNotIn

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/style/justify-left-crash.html

Issue 960353002: Handle null baseStyle in getPropertiesNotIn (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add test Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <HTML hidden>

	3 <style>

	4 html, head, style {

	5 display: block;

	6 }

	7 </style>

	8 <script>

	9 document.designMode = 'on';

	10 document.execCommand("selectAll", true , null);
	yosin_UTC9 2015/03/10 05:27:07 nit: We don't need to have \|true\| and \|null\|. "Sel nit: We don't need to have \|true\| and \|null\|. "SelectAll" command doesn't take parameters. rwlbuis 2015/03/10 23:44:21 Done. Show quoted text On 2015/03/10 05:27:07, Yosi_UTC9 wrote: > nit: We don't need to have \|true\| and \|null\|. "SelectAll" command doesn't take > parameters. Done.
	11 document.execCommand("italic", false , null);
	yosin_UTC9 2015/03/10 05:27:07 nit: We don't need to have \|false\| and \|null\|. The nit: We don't need to have \|false\| and \|null\|. These are default parameter values. rwlbuis 2015/03/10 23:44:21 Done. Show quoted text On 2015/03/10 05:27:07, Yosi_UTC9 wrote: > nit: We don't need to have \|false\| and \|null\|. These are default parameter > values. Done.
	12 document.execCommand("justifyLeft", false , null);
	yosin_UTC9 2015/03/10 05:27:07 nit: We don't need to have \|false\| and \|null\|. The nit: We don't need to have \|false\| and \|null\|. These are default parameter values. rwlbuis 2015/03/10 23:44:21 Done. Show quoted text On 2015/03/10 05:27:07, Yosi_UTC9 wrote: > nit: We don't need to have \|false\| and \|null\|. These are default parameter > values. Done.
	13 </script>
	yosin_UTC9 2015/03/10 05:27:07 Could you add output of this test to avoid empty e Could you add output of this test to avoid empty expectation? We usually print "PASS if Blink doesn't crash." or so. rwlbuis 2015/03/10 23:44:21 I tried but it is hard, the hidden attribute in ht Show quoted text On 2015/03/10 05:27:07, Yosi_UTC9 wrote: > Could you add output of this test to avoid empty expectation? > We usually print "PASS if Blink doesn't crash." or so. I tried but it is hard, the hidden attribute in html makes the whole document hidden.
OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/editing/style/justify-left-crash-expected.html » ('j') | Source/core/editing/EditingStyle.cpp » ('J')