Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: test/mjsunit/es7/object-observe.js

Issue 960343002: ES6: Make function name configurable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cleanup Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/mjsunit/es7/object-observe.js
diff --git a/test/mjsunit/es7/object-observe.js b/test/mjsunit/es7/object-observe.js
index 5af205eadf88f894685efda34256d2acb4800b50..2c281eb8fc6876c0f227fbdb327c4e045b1a4aaf 100644
--- a/test/mjsunit/es7/object-observe.js
+++ b/test/mjsunit/es7/object-observe.js
@@ -996,6 +996,10 @@ function TestObserveConfigurable(obj, prop) {
Object.defineProperty(obj, prop, {value: 6});
Object.defineProperty(obj, prop, {writable: false});
obj[prop] = 7; // ignored
+
+ // FIXME
+ assertTrue(Object.getOwnPropertyDescriptor(obj, prop).configurable);
arv (Not doing code reviews) 2015/02/27 15:44:33 This happens in the stress test. Not sure why yet.
arv (Not doing code reviews) 2015/02/27 16:23:15 I figured it out. This failing has nothing to do w
+
Object.defineProperty(obj, prop, {value: 8});
Object.defineProperty(obj, prop, {value: 7, writable: true});
Object.defineProperty(obj, prop, {get: function() {}});
@@ -1142,7 +1146,7 @@ var properties = ["a", "1", 1, "length", "setPrototype", "name", "caller"];
function blacklisted(obj, prop) {
return (obj instanceof Int32Array && prop == 1) ||
(obj instanceof Int32Array && prop === "length") ||
- (obj instanceof ArrayBuffer && prop == 1)
+ (obj instanceof ArrayBuffer && prop == 1);
}
for (var i in objects) for (var j in properties) {

Powered by Google App Engine
This is Rietveld 408576698