Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Side by Side Diff: test/mjsunit/es7/object-observe.js

Issue 960343002: ES6: Make function name configurable (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Use reconfigure instead Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « test/mjsunit/es6/function-name-configurable.js ('k') | test/mjsunit/regress/regress-1530.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1124 matching lines...) Expand 10 before | Expand all | Expand 10 after
1135 // TODO(rafaelw) Enable when ES6 Proxies are implemented. 1135 // TODO(rafaelw) Enable when ES6 Proxies are implemented.
1136 // createProxy(Proxy.create, null), 1136 // createProxy(Proxy.create, null),
1137 // createProxy(Proxy.createFunction, function(){}), 1137 // createProxy(Proxy.createFunction, function(){}),
1138 ]; 1138 ];
1139 var properties = ["a", "1", 1, "length", "setPrototype", "name", "caller"]; 1139 var properties = ["a", "1", 1, "length", "setPrototype", "name", "caller"];
1140 1140
1141 // Cases that yield non-standard results. 1141 // Cases that yield non-standard results.
1142 function blacklisted(obj, prop) { 1142 function blacklisted(obj, prop) {
1143 return (obj instanceof Int32Array && prop == 1) || 1143 return (obj instanceof Int32Array && prop == 1) ||
1144 (obj instanceof Int32Array && prop === "length") || 1144 (obj instanceof Int32Array && prop === "length") ||
1145 (obj instanceof ArrayBuffer && prop == 1) 1145 (obj instanceof ArrayBuffer && prop == 1) ||
1146 (obj instanceof Function && prop === "name"); // Has its own test.
1146 } 1147 }
1147 1148
1148 for (var i in objects) for (var j in properties) { 1149 for (var i in objects) for (var j in properties) {
1149 var obj = objects[i]; 1150 var obj = objects[i];
1150 var prop = properties[j]; 1151 var prop = properties[j];
1151 if (blacklisted(obj, prop)) continue; 1152 if (blacklisted(obj, prop)) continue;
1152 var desc = Object.getOwnPropertyDescriptor(obj, prop); 1153 var desc = Object.getOwnPropertyDescriptor(obj, prop);
1153 print("***", typeof obj, stringifyNoThrow(obj), prop); 1154 print("***", typeof obj, stringifyNoThrow(obj), prop);
1154 if (!desc || desc.configurable) 1155 if (!desc || desc.configurable)
1155 TestObserveConfigurable(obj, prop); 1156 TestObserveConfigurable(obj, prop);
(...skipping 635 matching lines...) Expand 10 before | Expand all | Expand 10 after
1791 for (var n1 = 0; n1 < 3; ++n1) 1792 for (var n1 = 0; n1 < 3; ++n1)
1792 for (var n2 = 0; n2 < 3; ++n2) 1793 for (var n2 = 0; n2 < 3; ++n2)
1793 for (var i in mutation) 1794 for (var i in mutation)
1794 TestFastElementsLength(mutation[i], b1 != 0, b2 != 0, 20*n1, 20*n2); 1795 TestFastElementsLength(mutation[i], b1 != 0, b2 != 0, 20*n1, 20*n2);
1795 1796
1796 for (var b1 = 0; b1 < 2; ++b1) 1797 for (var b1 = 0; b1 < 2; ++b1)
1797 for (var b2 = 0; b2 < 2; ++b2) 1798 for (var b2 = 0; b2 < 2; ++b2)
1798 for (var n = 0; n < 3; ++n) 1799 for (var n = 0; n < 3; ++n)
1799 for (var i in mutationByIncr) 1800 for (var i in mutationByIncr)
1800 TestFastElementsLength(mutationByIncr[i], b1 != 0, b2 != 0, 7*n, 7*n+1); 1801 TestFastElementsLength(mutationByIncr[i], b1 != 0, b2 != 0, 7*n, 7*n+1);
1802
1803
1804 (function TestFunctionName() {
1805 reset();
1806
1807 function fun() {}
1808 Object.observe(fun, observer.callback);
1809 fun.name = 'x'; // No change. Not writable.
1810 Object.defineProperty(fun, 'name', {value: 'a'});
1811 Object.defineProperty(fun, 'name', {writable: true});
1812 fun.name = 'b';
1813 delete fun.name;
1814 fun.name = 'x'; // No change. Function.prototype.name is non writable
1815 Object.defineProperty(Function.prototype, 'name', {writable: true});
1816 fun.name = 'c';
1817 fun.name = 'c'; // Same, no update.
1818 Object.deliverChangeRecords(observer.callback);
1819 observer.assertCallbackRecords([
1820 { object: fun, type: 'update', name: 'name', oldValue: 'fun' },
1821 { object: fun, type: 'reconfigure', name: 'name'},
1822 { object: fun, type: 'update', name: 'name', oldValue: 'a' },
1823 { object: fun, type: 'delete', name: 'name', oldValue: 'b' },
1824 { object: fun, type: 'add', name: 'name' },
1825 ]);
1826 })();
OLDNEW
« no previous file with comments | « test/mjsunit/es6/function-name-configurable.js ('k') | test/mjsunit/regress/regress-1530.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698