ES6: Make function name configurable

test/mjsunit/es7/object-observe.js

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 978 matching lines @@
   Object.observe(obj, observer.callback);
   obj[prop] = 2;
   obj[prop] = 3;
   delete obj[prop];
   obj[prop] = 4;
   obj[prop] = 4;  // ignored
   obj[prop] = 5;
   Object.defineProperty(obj, prop, {value: 6});
   Object.defineProperty(obj, prop, {writable: false});
   obj[prop] = 7;  // ignored
+
+  // FIXME
+  assertTrue(Object.getOwnPropertyDescriptor(obj, prop).configurable);

[arv (Not doing code reviews), 2015/02/27 15:44:33]

This happens in the stress test. Not sure why yet. Still investigating.

[arv (Not doing code reviews), 2015/02/27 16:23:15]

I figured it out. This failing has nothing to do with the C++ code. It is becase
F.p.name is non writable so line 993, 994, 995 do not create an own property.
The we hit line 996 and create a non configurable property. Yikes.

I'll black list Function name and write a dedicated test for it instead.

+
   Object.defineProperty(obj, prop, {value: 8});
   Object.defineProperty(obj, prop, {value: 7, writable: true});
   Object.defineProperty(obj, prop, {get: function() {}});
   Object.defineProperty(obj, prop, {get: frozenFunction});
   Object.defineProperty(obj, prop, {get: frozenFunction});  // ignored
   Object.defineProperty(obj, prop, {get: frozenFunction, set: frozenFunction});
   Object.defineProperty(obj, prop, {set: frozenFunction});  // ignored
   Object.defineProperty(obj, prop, {get: undefined, set: frozenFunction});
   obj.__defineSetter__(prop, frozenFunction);  // ignored
   obj.__defineSetter__(prop, function() {});
@@ skipping 126 matching lines @@
 // TODO(rafaelw) Enable when ES6 Proxies are implemented.
 //  createProxy(Proxy.create, null),
 //  createProxy(Proxy.createFunction, function(){}),
 ];
 var properties = ["a", "1", 1, "length", "setPrototype", "name", "caller"];
 
 // Cases that yield non-standard results.
 function blacklisted(obj, prop) {
   return (obj instanceof Int32Array && prop == 1) ||
          (obj instanceof Int32Array && prop === "length") ||
-         (obj instanceof ArrayBuffer && prop == 1)
+         (obj instanceof ArrayBuffer && prop == 1);
 }
 
 for (var i in objects) for (var j in properties) {
   var obj = objects[i];
   var prop = properties[j];
   if (blacklisted(obj, prop)) continue;
   var desc = Object.getOwnPropertyDescriptor(obj, prop);
   print("***", typeof obj, stringifyNoThrow(obj), prop);
   if (!desc || desc.configurable)
     TestObserveConfigurable(obj, prop);
@@ skipping 635 matching lines @@
     for (var n1 = 0; n1 < 3; ++n1)
       for (var n2 = 0; n2 < 3; ++n2)
         for (var i in mutation)
           TestFastElementsLength(mutation[i], b1 != 0, b2 != 0, 20*n1, 20*n2);
 
 for (var b1 = 0; b1 < 2; ++b1)
   for (var b2 = 0; b2 < 2; ++b2)
     for (var n = 0; n < 3; ++n)
       for (var i in mutationByIncr)
         TestFastElementsLength(mutationByIncr[i], b1 != 0, b2 != 0, 7*n, 7*n+1);