Fix handling of media files in InspectorFileSystemAgent

Fix handling of media files in InspectorFileSystemAgent

Here is the piece of code that categorizes various file types:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/modules/filesystem/InspectorFileSystemAgent.cpp&rcl=1424812033&l=280
Note that it doesn't handle media (audio/video, e.g. "audio/mp3",
"video/mp4" and so on) types explicitly. Currently
MIMETypeRegistry::isSupportedNonImageMIMEType will return true for
supported media types, and that will cause media files to be reported
as ResourceType::Document and we'll do
entryForFrontend->setIsTextFile(true) for media files as well.

BUG=462329
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200949

[servolk, 2015-02-26 19:34:05]

servolk@chromium.org changed reviewers:
+ kinuko@chromium.org, michaeln@chromium.org, nhiroki@chromium.org,
tzik@chromium.org

[servolk, 2015-02-26 19:34:58]

PTAL, I think this is the right thing to do.
By the way, are there any unit tests that cover this functionality? I'd love to
add some unit test coverage for this, but couldn't find the appropriate unit
test quickly.

[michaeln, 2015-02-26 21:54:11]

lgtm, it'd be good to cc some inspector folks on the change

[servolk, 2015-02-26 21:56:50]

On 2015/02/26 21:54:11, michaeln wrote:
> lgtm, it'd be good to cc some inspector folks on the change

I've added everybody from Source/modules/filesystem/OWNERS on the review list,
should I add somebody else?

[michaeln, 2015-02-26 23:32:21]

michaeln@chromium.org changed reviewers:
+ pfeldman@chromium.org

[michaeln, 2015-02-26 23:33:50]

added pavel (pfeldman)

> I've added everybody from Source/modules/filesystem/OWNERS on the review list,
> should I add somebody else?

[pfeldman, 2015-03-02 12:45:51]

lgtm

[servolk, 2015-03-02 17:52:06]

The CQ bit was checked by servolk@chromium.org

[commit-bot: I haz the power, 2015-03-02 17:52:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960333002/1

[commit-bot: I haz the power, 2015-03-02 18:19:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-02 18:19:52]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

[pfeldman, 2015-05-15 23:49:30]

On 2015/03/02 18:19:52, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   android_chromium_gn_compile_rel on tryserver.blink (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)

Do you want to land this?

[servolk, 2015-05-16 01:20:46]

On 2015/05/15 23:49:30, pfeldman_slow wrote:
> On 2015/03/02 18:19:52, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   android_chromium_gn_compile_rel on tryserver.blink (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)
> 
> Do you want to land this?

Yes, I still want to land this eventually, I think this is the right thing to
do, just not very high priority. Although ideally I was hoping to find a way to
use MimeUtil::IsSupportedMediaMimeType instead of
MIMETypeRegistry::isSupportedMediaSourceMIMEType here, since the latter supports
only MSE mime types, which is a subset of HTMLMediaElement.canPlayType media
types supported by the former. But it looks like
MimeUtil::IsSupportedMediaMimeType is currently not easily accessible in blink
(not exposed through MIMETypeRegistry interface), and I wanted to figure out how
to do that, but got distracted by other work. I'll try to find some time to
finish this.

[pfeldman, 2015-05-17 01:41:03]

sg, there is no rush. I was just triaging my reviewer inbox. Please re-add me to
the reviewers list once you have it updated.

[pfeldman, 2015-05-17 01:41:14]

pfeldman@chromium.org changed reviewers:
- pfeldman@chromium.org

[servolk, 2015-08-14 23:45:07]

On 2015/05/17 01:41:03, pfeldman wrote:
> sg, there is no rush. I was just triaging my reviewer inbox. Please re-add me
to
> the reviewers list once you have it updated.

PTAL, I've found HTMLMediaElement::supportsType method which is exactly what we
need here, since it covers all media mime types supported by HTMLMediaElement,
as opposed to MIMETypeRegistry::isSupportedMediaSourceMIMEType, which only
covers MSE types.

[servolk, 2015-08-18 02:38:12]

On 2015/08/14 23:45:07, servolk wrote:
> On 2015/05/17 01:41:03, pfeldman wrote:
> > sg, there is no rush. I was just triaging my reviewer inbox. Please re-add
me
> to
> > the reviewers list once you have it updated.
> 
> PTAL, I've found HTMLMediaElement::supportsType method which is exactly what
we
> need here, since it covers all media mime types supported by HTMLMediaElement,
> as opposed to MIMETypeRegistry::isSupportedMediaSourceMIMEType, which only
> covers MSE types.

ping

[servolk, 2015-08-19 17:56:06]

On 2015/08/18 02:38:12, servolk wrote:
> On 2015/08/14 23:45:07, servolk wrote:
> > On 2015/05/17 01:41:03, pfeldman wrote:
> > > sg, there is no rush. I was just triaging my reviewer inbox. Please re-add
> me
> > to
> > > the reviewers list once you have it updated.
> > 
> > PTAL, I've found HTMLMediaElement::supportsType method which is exactly what
> we
> > need here, since it covers all media mime types supported by
HTMLMediaElement,
> > as opposed to MIMETypeRegistry::isSupportedMediaSourceMIMEType, which only
> > covers MSE types.
> 
> ping

ping

[servolk, 2015-08-20 16:47:36]

The CQ bit was checked by servolk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-20 16:47:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/960333002/20001

[commit-bot: I haz the power, 2015-08-20 22:57:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-20 22:57:22]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[servolk, 2015-08-21 01:14:58]

The CQ bit was checked by servolk@chromium.org

[servolk, 2015-08-21 01:14:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaeln@chromium.org, pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/960333002/#ps20001 (title:
"Use HTMLMediaElement::supportsType instead of MIMETypeRegistry")

[commit-bot: I haz the power, 2015-08-21 01:15:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960333002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/960333002/20001

[commit-bot: I haz the power, 2015-08-21 02:01:38]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200949