Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: ui/ozone/platform/dri/hardware_display_controller_unittest.cc

Issue 960273003: ozone: dri: add synchronous SwapBuffers support on surfaceless (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Schedule asynchronous flip correctly on flip callback Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/dri/hardware_display_controller_unittest.cc
diff --git a/ui/ozone/platform/dri/hardware_display_controller_unittest.cc b/ui/ozone/platform/dri/hardware_display_controller_unittest.cc
index 2d1b467dfe96a345f1cb5193b652e82a44d5a7d1..2c9b60f4d20ec078323e884f06b7b04ac6c001f7 100644
--- a/ui/ozone/platform/dri/hardware_display_controller_unittest.cc
+++ b/ui/ozone/platform/dri/hardware_display_controller_unittest.cc
@@ -103,6 +103,7 @@ TEST_F(HardwareDisplayControllerTest, CheckStateAfterPageFlip) {
new MockScanoutBuffer(kDefaultModeSize)));
controller_->QueueOverlayPlane(plane2);
EXPECT_TRUE(controller_->SchedulePageFlip(
+ false,
base::Bind(&HardwareDisplayControllerTest::PageFlipCallback,
base::Unretained(this))));
drm_->RunCallbacks();
@@ -134,6 +135,7 @@ TEST_F(HardwareDisplayControllerTest, CheckStateIfPageFlipFails) {
new MockScanoutBuffer(kDefaultModeSize)));
controller_->QueueOverlayPlane(plane2);
EXPECT_FALSE(controller_->SchedulePageFlip(
+ false,
base::Bind(&HardwareDisplayControllerTest::PageFlipCallback,
base::Unretained(this))));
drm_->RunCallbacks();
@@ -152,6 +154,7 @@ TEST_F(HardwareDisplayControllerTest, VerifyNoDRMCallsWhenDisabled) {
new MockScanoutBuffer(kDefaultModeSize)));
controller_->QueueOverlayPlane(plane2);
EXPECT_TRUE(controller_->SchedulePageFlip(
+ false,
base::Bind(&HardwareDisplayControllerTest::PageFlipCallback,
base::Unretained(this))));
drm_->RunCallbacks();
@@ -160,6 +163,7 @@ TEST_F(HardwareDisplayControllerTest, VerifyNoDRMCallsWhenDisabled) {
EXPECT_TRUE(controller_->Modeset(plane1, kDefaultMode));
controller_->QueueOverlayPlane(plane2);
EXPECT_TRUE(controller_->SchedulePageFlip(
+ false,
base::Bind(&HardwareDisplayControllerTest::PageFlipCallback,
base::Unretained(this))));
drm_->RunCallbacks();
@@ -182,6 +186,7 @@ TEST_F(HardwareDisplayControllerTest, CheckOverlayPresent) {
controller_->QueueOverlayPlane(plane2);
EXPECT_TRUE(controller_->SchedulePageFlip(
+ false,
base::Bind(&HardwareDisplayControllerTest::PageFlipCallback,
base::Unretained(this))));
drm_->RunCallbacks();
@@ -202,6 +207,7 @@ TEST_F(HardwareDisplayControllerTest, PageflipMirroredControllers) {
new MockScanoutBuffer(kDefaultModeSize)));
controller_->QueueOverlayPlane(plane2);
EXPECT_TRUE(controller_->SchedulePageFlip(
+ false,
base::Bind(&HardwareDisplayControllerTest::PageFlipCallback,
base::Unretained(this))));
drm_->RunCallbacks();
@@ -215,6 +221,7 @@ TEST_F(HardwareDisplayControllerTest, PlaneStateAfterRemoveCrtc) {
EXPECT_TRUE(controller_->Modeset(plane1, kDefaultMode));
controller_->QueueOverlayPlane(plane1);
EXPECT_TRUE(controller_->SchedulePageFlip(
+ false,
base::Bind(&HardwareDisplayControllerTest::PageFlipCallback,
base::Unretained(this))));
drm_->RunCallbacks();
@@ -237,6 +244,7 @@ TEST_F(HardwareDisplayControllerTest, ModesetWhilePageFlipping) {
EXPECT_TRUE(controller_->Modeset(plane1, kDefaultMode));
controller_->QueueOverlayPlane(plane1);
EXPECT_TRUE(controller_->SchedulePageFlip(
+ false,
base::Bind(&HardwareDisplayControllerTest::PageFlipCallback,
base::Unretained(this))));
@@ -251,6 +259,7 @@ TEST_F(HardwareDisplayControllerTest, AddCrtcMidPageFlip) {
EXPECT_TRUE(controller_->Modeset(plane1, kDefaultMode));
controller_->QueueOverlayPlane(plane1);
EXPECT_TRUE(controller_->SchedulePageFlip(
+ false,
base::Bind(&HardwareDisplayControllerTest::PageFlipCallback,
base::Unretained(this))));
@@ -267,6 +276,7 @@ TEST_F(HardwareDisplayControllerTest, RemoveCrtcMidPageFlip) {
EXPECT_TRUE(controller_->Modeset(plane1, kDefaultMode));
controller_->QueueOverlayPlane(plane1);
EXPECT_TRUE(controller_->SchedulePageFlip(
+ false,
base::Bind(&HardwareDisplayControllerTest::PageFlipCallback,
base::Unretained(this))));

Powered by Google App Engine
This is Rietveld 408576698