Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: ui/ozone/platform/dri/hardware_display_controller.cc

Issue 960273003: ozone: dri: add synchronous SwapBuffers support on surfaceless (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update after dnicoara's review Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/platform/dri/hardware_display_controller.cc
diff --git a/ui/ozone/platform/dri/hardware_display_controller.cc b/ui/ozone/platform/dri/hardware_display_controller.cc
index 0bd49477e857fcabbd05c7c4a4ec1a41bf88c5dc..807c5f93b0c0f22d81f330075cd14c9401e3a092 100644
--- a/ui/ozone/platform/dri/hardware_display_controller.cc
+++ b/ui/ozone/platform/dri/hardware_display_controller.cc
@@ -89,6 +89,7 @@ void HardwareDisplayController::QueueOverlayPlane(const OverlayPlane& plane) {
}
bool HardwareDisplayController::SchedulePageFlip(
+ bool is_sync,
const base::Closure& callback) {
TRACE_EVENT0("dri", "HDC::SchedulePageFlip");
@@ -105,7 +106,7 @@ bool HardwareDisplayController::SchedulePageFlip(
if (HasPendingPageFlips())
return true;
- bool status = ActualSchedulePageFlip();
+ bool status = ActualSchedulePageFlip(is_sync);
// No page flip event on failure so discard failed request.
if (!status)
@@ -246,7 +247,7 @@ void HardwareDisplayController::OnPageFlipEvent() {
return;
// At this point we still have requests pending, so schedule the next request.
- bool status = ActualSchedulePageFlip();
+ bool status = ActualSchedulePageFlip(false);
dnicoara 2015/02/26 22:16:29 Then |is_sync| will be taken from the PageFlipRequ
llandwerlin-old 2015/02/27 10:56:47 Done, thanks a lot.
if (!status) {
PageFlipRequest request = requests_.front();
requests_.pop_front();
@@ -274,7 +275,7 @@ bool HardwareDisplayController::HasPendingPageFlips() const {
return false;
}
-bool HardwareDisplayController::ActualSchedulePageFlip() {
+bool HardwareDisplayController::ActualSchedulePageFlip(bool is_sync) {
TRACE_EVENT0("dri", "HDC::ActualSchedulePageFlip");
DCHECK(!requests_.empty());
@@ -297,7 +298,7 @@ bool HardwareDisplayController::ActualSchedulePageFlip() {
}
for (const auto& planes : owned_hardware_planes_) {
- if (!planes.first->plane_manager()->Commit(planes.second)) {
+ if (!planes.first->plane_manager()->Commit(planes.second, is_sync)) {
status = false;
}
}

Powered by Google App Engine
This is Rietveld 408576698