Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: src/isolate.cc

Issue 960273002: Move stack unwinding logic into the runtime. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Simplify further. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 24df06a012f1e9ca19caf68d8dab3fef7e3e1908..8dd869363fa375d4c60886aa1a6ed7a7dea794d4 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -910,6 +910,44 @@ Object* Isolate::ReThrow(Object* exception) {
}
+Object* Isolate::FindHandler() {
+ Object* exception = pending_exception();
+
+ // Determine target stack handler. Special handling of termination exceptions
+ // which are uncatchable by JavaScript code, we unwind the handlers until the
+ // top ENTRY handler is found.
+ StackHandler* handler =
+ StackHandler::FromAddress(Isolate::handler(thread_local_top()));
+ if (!is_catchable_by_javascript(exception)) {
+ while (!handler->is_js_entry()) handler = handler->next();
+ }
+
+ // Restore the next handler.
+ thread_local_top_.handler_ = handler->next()->address();
+
+ // Compute handler and stack unwinding information.
+ // TODO(mstarzinger): Extend this to perform actual stack-walk and take into
+ // account that TurboFan code can contain handlers as well.
+ Code* code = handler->code();
+ Context* context = handler->is_js_entry() ? nullptr : handler->context();
+ int offset = Smi::cast(code->handler_table()->get(handler->index()))->value();
+ Address handler_sp = handler->address() + StackHandlerConstants::kSize;
+ Address handler_fp = handler->frame_pointer();
+
+
+ // Store information to be consumed by the CEntryStub.
+ thread_local_top_.pending_handler_context_ = context;
+ thread_local_top_.pending_handler_code_ = code;
+ thread_local_top_.pending_handler_offset_ = offset;
+ thread_local_top_.pending_handler_fp_ = handler_fp;
+ thread_local_top_.pending_handler_sp_ = handler_sp;
+
+ // Return and clear pending exception.
+ clear_pending_exception();
+ return exception;
+}
+
+
Object* Isolate::ThrowIllegalOperation() {
if (FLAG_stack_trace_on_illegal) PrintStack(stdout);
return Throw(heap_.illegal_access_string());
@@ -1286,6 +1324,7 @@ void Isolate::DoThrow(Object* exception, MessageLocation* location) {
thread_local_top()->catcher_ = can_be_caught_externally ?
try_catch_handler() : NULL;
+ // Set the exception being thrown.
set_pending_exception(*exception_handle);
}
« src/ia32/code-stubs-ia32.cc ('K') | « src/isolate.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698