Issue 960233007: Add super-primitive shelldb

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 960233007: Add super-primitive shelldb (Closed)

Created:
5 years, 9 months ago by eseidel

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add super-primitive shelldb This is basically skydb v2, except only for android. I revisited some of the architecture decisions I made in writing skydb. I also separated skyserver.py from dependency on skypy/paths.py since it wasn't really adding any value. We could make this way fancier, but this should at least make working with SkyDemo.apk easier for now. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c1fb7feafa30c74d20a99baeb8ba66c6bf8bdf41

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+220 lines, -11 lines)			Patch
M	mojo/tools/mojo_demo.py	View	1 chunk	+1 line, -2 lines	0 comments	Download
A	sky/tools/shelldb	View	1 chunk	+208 lines, -0 lines	0 comments	Download
M	sky/tools/skydb	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/tools/skypy/skyserver.py	View	3 chunks	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

5 years, 9 months ago (2015-03-03 18:55:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c1fb7feafa30c74d20a99baeb8ba66c6bf8bdf41 (presubmit successful).

Expand Messages | Collapse Messages