Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1281)

Unified Diff: Source/core/page/Page.cpp

Issue 960223002: Detach SpeechRecognitionController upon page detach. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adjust assert and allow repeated observer detaches Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/Page.cpp
diff --git a/Source/core/page/Page.cpp b/Source/core/page/Page.cpp
index ed22d5b087d8e955b7f9412e52500df60af7ab18..7559876f6750e59213bd506d88a84c9d97630a76 100644
--- a/Source/core/page/Page.cpp
+++ b/Source/core/page/Page.cpp
@@ -610,6 +610,7 @@ void Page::willBeDestroyed()
m_mainFrame = nullptr;
Page::notifyContextDestroyed();
+ Page::detachObservers();
haraken 2015/02/26 16:29:05 Hmm, I might want to avoid introducing another lif
sof 2015/02/26 17:01:22 Yes, the explicit clearing here is not without pro
}
Page::PageClients::PageClients()

Powered by Google App Engine
This is Rietveld 408576698