LayoutTests/fast/speech/scripted/speechrecognition-detached-no-crash.html - Issue 960223002: Detach SpeechRecognitionController upon page detach.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/speech/scripted/speechrecognition-detached-no-crash.html

Issue 960223002: Detach SpeechRecognitionController upon page detach. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Adjust assert and allow repeated observer detaches Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML>

	2 <html>

	3 <head>

	4 <script src="../../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 description("Accessing SpeechRecognition on a detached window should not crash." );

	9

	10 window.jsTestIsAsync = true;

	11

	12 if (window.testRunner) {

	13 testRunner.dumpAsText();

	14 testRunner.waitUntilDone();

	15 testRunner.setCanOpenWindows();

	16 }

	17

	18 var w;

	19 var recognition;

	20

	21 function processMessage(event) {

	22 if (event.data == "opened") {

	23 recognition = new w.webkitSpeechRecognition();

	24 w.close();

	25 } else if (event.data == "closed") {

	26 shouldBeUndefined("recognition.start()");

	27 shouldBeUndefined("recognition.stop()");

	28 shouldBeUndefined("recognition.abort()");

	29 finishJSTest();

	30 }

	31 }

	32

	33 w = window.open('../../../resources/window-postmessage-open-close.html');

	34 window.addEventListener("message", processMessage, false);

	35 </script>

	36 </body>

	37 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/speech/scripted/speechrecognition-detached-no-crash-expected.txt » ('j') | Source/core/page/Page.cpp » ('J')