Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 960213007: Don't apply pointer multipler to heap sizes on Android. (Closed)

Created:
5 years, 9 months ago by rmcilroy
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't apply pointer multipler to heap sizes on Android. Android doesn't have swap space so if the heap goes over the physical memory size the system will just kill us. Applying the Heap::kPointerMultipler to heap size could cause the max heap size to be larger than physical memory. Instead use the defaults which are based on actual physical memory configured by Api::ConfigureDefaults(). BUG=432909 LOG=N Committed: https://crrev.com/7611aace3e7bf6a3a25deb899ff2dc3bab1a8e66 Cr-Commit-Position: refs/heads/master@{#26954}

Patch Set 1 #

Patch Set 2 : Fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/heap/heap.h View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rmcilroy
Hannes: PTAL, thanks. This is to fix crbug.com/432909
5 years, 9 months ago (2015-03-02 21:50:28 UTC) #2
Hannes Payer (out of office)
LGTM, this change will tank 64-bit android devices.
5 years, 9 months ago (2015-03-02 22:04:27 UTC) #3
rmcilroy
On 2015/03/02 22:04:27, Hannes Payer wrote: > LGTM, this change will tank 64-bit android devices. ...
5 years, 9 months ago (2015-03-03 10:14:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960213007/20001
5 years, 9 months ago (2015-03-03 10:16:05 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 10:19:03 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 10:19:13 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7611aace3e7bf6a3a25deb899ff2dc3bab1a8e66
Cr-Commit-Position: refs/heads/master@{#26954}

Powered by Google App Engine
This is Rietveld 408576698