Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 960213006: Web MIDI: newly attached device was not registered to listen (Closed)

Created:
5 years, 9 months ago by Takashi Toyoshima
Modified:
5 years, 9 months ago
Reviewers:
yhirano
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: newly attached device was not registered to listen Newly added MIDI input ports were detected and enumerated correctly, but was not registered to listen. As a result, incoming MIDI messages are not received at all. BUG=n/a TEST=manual Committed: https://crrev.com/817e5460e9b9419937e9e5fe7a0f8f0874087770 Cr-Commit-Position: refs/heads/master@{#318655}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M media/midi/midi_manager_mac.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Takashi Toyoshima
ptal
5 years, 9 months ago (2015-02-27 18:04:20 UTC) #2
yhirano
lgtm
5 years, 9 months ago (2015-03-02 05:41:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960213006/1
5 years, 9 months ago (2015-03-02 06:08:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 06:44:58 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 06:45:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/817e5460e9b9419937e9e5fe7a0f8f0874087770
Cr-Commit-Position: refs/heads/master@{#318655}

Powered by Google App Engine
This is Rietveld 408576698