Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 960193002: Clean up DictionaryHelperForCore.cpp (Closed)

Created:
5 years, 10 months ago by Jens Widell
Modified:
5 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Clean up DictionaryHelperForCore.cpp - Remove uses of TONATIVE_* and TOSTRING_* macros. - Remove various unneeded explicit template specializations/instantiations. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190922

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -129 lines) Patch
M Source/bindings/core/v8/DictionaryHelperForCore.cpp View 7 chunks +17 lines, -129 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
Jens Widell
PTAL https://codereview.chromium.org/960193002/diff/1/Source/bindings/core/v8/DictionaryHelperForCore.cpp File Source/bindings/core/v8/DictionaryHelperForCore.cpp (right): https://codereview.chromium.org/960193002/diff/1/Source/bindings/core/v8/DictionaryHelperForCore.cpp#newcode542 Source/bindings/core/v8/DictionaryHelperForCore.cpp:542: template bool DictionaryHelper::convert(const Dictionary&, Dictionary::ConversionContext&, const String& key, ...
5 years, 10 months ago (2015-02-26 13:30:40 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-26 13:41:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960193002/1
5 years, 10 months ago (2015-02-26 14:19:25 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 15:30:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190922

Powered by Google App Engine
This is Rietveld 408576698