Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 960133007: Devtools: Update CSS property weights in CSSMetaData (Closed)

Created:
5 years, 9 months ago by samli
Modified:
5 years, 9 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools: Update CSS property weights in CSSMetaData The popularity of CSS properties is used to determine auto selection in auto completion in Styles. The data used is several years out of date, is missing properties and inaccurate. This change updates these values using data from https://www.chromestatus.com/metrics/css/popularity and includes any CSS property used in more than 1% of webpages. BUG=463775 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191407

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -116 lines) Patch
M Source/devtools/front_end/sdk/CSSMetadata.js View 1 1 chunk +256 lines, -116 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
samli
PTAL
5 years, 9 months ago (2015-03-04 04:29:17 UTC) #2
pfeldman
lgtm
5 years, 9 months ago (2015-03-05 20:40:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960133007/1
5 years, 9 months ago (2015-03-05 23:15:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960133007/20001
5 years, 9 months ago (2015-03-06 00:40:26 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 03:56:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191407

Powered by Google App Engine
This is Rietveld 408576698