Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 960133002: Js fixed for proper status setting on HID screen. (Closed)

Created:
5 years, 10 months ago by merkulova
Modified:
5 years, 10 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Js fixed for proper status setting on HID screen. BUG=461076 Committed: https://crrev.com/9ba382d13df47c67e1128614279a1ff01c28aae6 Cr-Commit-Position: refs/heads/master@{#318225}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Continue-button doubled logic removed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js View 1 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
merkulova
5 years, 10 months ago (2015-02-26 11:03:17 UTC) #2
Nikita (slow)
https://codereview.chromium.org/960133002/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js File chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js (right): https://codereview.chromium.org/960133002/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js#newcode178 chrome/browser/resources/chromeos/login/oobe_screen_hid_detection.js:178: var keyboardState = this.context.get(CONTEXT_KEY_KEYBOARD_STATE, ''); As discussed, please move ...
5 years, 10 months ago (2015-02-26 12:10:08 UTC) #3
merkulova
Removed js logic.
5 years, 10 months ago (2015-02-26 12:21:55 UTC) #4
Nikita (slow)
On 2015/02/26 12:21:55, merkulova wrote: > Removed js logic. I don't see any changes in ...
5 years, 10 months ago (2015-02-26 12:28:19 UTC) #5
Nikita (slow)
lgtm
5 years, 10 months ago (2015-02-26 12:33:41 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960133002/20001
5 years, 10 months ago (2015-02-26 12:36:53 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 13:14:51 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 13:15:33 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ba382d13df47c67e1128614279a1ff01c28aae6
Cr-Commit-Position: refs/heads/master@{#318225}

Powered by Google App Engine
This is Rietveld 408576698