Use node accessors to check for const/final/etc.

pkg/analyzer/lib/src/generated/resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.resolver;
 
 import "dart:math" as math;
 import 'dart:collection';
 
 import 'package:analyzer/src/generated/utilities_collection.dart';
@@ skipping 2606 matching lines @@
       element.periodOffset = node.period.offset;
       element.nameEnd = constructorName.end;
     }
     holder.validate();
     return null;
   }
 
   @override
   Object visitDeclaredIdentifier(DeclaredIdentifier node) {
     SimpleIdentifier variableName = node.identifier;
-    sc.Token keyword = node.keyword;
     LocalVariableElementImpl element =
         new LocalVariableElementImpl.forNode(variableName);
     ForEachStatement statement = node.parent as ForEachStatement;
     int declarationEnd = node.offset + node.length;
     int statementEnd = statement.offset + statement.length;
     element.setVisibleRange(declarationEnd, statementEnd - declarationEnd - 1);
-    element.const3 = _matches(keyword, sc.Keyword.CONST);
-    element.final2 = _matches(keyword, sc.Keyword.FINAL);
+    element.const3 = node.isConst;
+    element.final2 = node.isFinal;
     _currentHolder.addLocalVariable(element);
     variableName.staticElement = element;
     return super.visitDeclaredIdentifier(node);
   }
 
   @override
   Object visitDefaultFormalParameter(DefaultFormalParameter node) {
     ElementHolder holder = new ElementHolder();
     NormalFormalParameter normalParameter = node.parameter;
     SimpleIdentifier parameterName = normalParameter.identifier;
@@ skipping 133 matching lines @@
         }
         String propertyName = propertyNameNode.name;
         TopLevelVariableElementImpl variable =
             _currentHolder.getTopLevelVariable(propertyName) as TopLevelVariableElementImpl;
         if (variable == null) {
           variable = new TopLevelVariableElementImpl(node.name.name, -1);
           variable.final2 = true;
           variable.synthetic = true;
           _currentHolder.addTopLevelVariable(variable);
         }
-        if (_matches(property, sc.Keyword.GET)) {
+        if (node.isGetter) {
           PropertyAccessorElementImpl getter =
               new PropertyAccessorElementImpl.forNode(propertyNameNode);
           getter.functions = holder.functions;
           getter.labels = holder.labels;
           getter.localVariables = holder.localVariables;
           if (body.isAsynchronous) {
             getter.asynchronous = true;
           }
           if (body.isGenerator) {
             getter.generator = true;
@@ skipping 172 matching lines @@
         String propertyName = propertyNameNode.name;
         FieldElementImpl field =
             _currentHolder.getField(propertyName) as FieldElementImpl;
         if (field == null) {
           field = new FieldElementImpl(node.name.name, -1);
           field.final2 = true;
           field.static = isStatic;
           field.synthetic = true;
           _currentHolder.addField(field);
         }
-        if (_matches(property, sc.Keyword.GET)) {
+        if (node.isGetter) {
           PropertyAccessorElementImpl getter =
               new PropertyAccessorElementImpl.forNode(propertyNameNode);
           getter.functions = holder.functions;
           getter.labels = holder.labels;
           getter.localVariables = holder.localVariables;
           if (body.isAsynchronous) {
             getter.asynchronous = true;
           }
           if (body.isGenerator) {
             getter.generator = true;
           }
           getter.variable = field;
-          getter.abstract =
-              body is EmptyFunctionBody && node.externalKeyword == null;
+          getter.abstract = node.isAbstract;
           getter.getter = true;
           getter.static = isStatic;
           field.getter = getter;
           _currentHolder.addAccessor(getter);
           propertyNameNode.staticElement = getter;
         } else {
           PropertyAccessorElementImpl setter =
               new PropertyAccessorElementImpl.forNode(propertyNameNode);
           setter.functions = holder.functions;
           setter.labels = holder.labels;
           setter.localVariables = holder.localVariables;
           setter.parameters = holder.parameters;
           if (body.isAsynchronous) {
             setter.asynchronous = true;
           }
           if (body.isGenerator) {
             setter.generator = true;
           }
           setter.variable = field;
-          setter.abstract = body is EmptyFunctionBody &&
-              !_matches(node.externalKeyword, sc.Keyword.EXTERNAL);
+          setter.abstract = node.isAbstract;
           setter.setter = true;
           setter.static = isStatic;
           field.setter = setter;
           field.final2 = false;
           _currentHolder.addAccessor(setter);
           propertyNameNode.staticElement = setter;
         }
       }
       holder.validate();
     } catch (exception, stackTrace) {
@@ skipping 86 matching lines @@
     TypeParameterTypeImpl typeParameterType =
         new TypeParameterTypeImpl(typeParameter);
     typeParameter.type = typeParameterType;
     _currentHolder.addTypeParameter(typeParameter);
     parameterName.staticElement = typeParameter;
     return super.visitTypeParameter(node);
   }
 
   @override
   Object visitVariableDeclaration(VariableDeclaration node) {
-    sc.Token keyword = (node.parent as VariableDeclarationList).keyword;
-    bool isConst = _matches(keyword, sc.Keyword.CONST);
-    bool isFinal = _matches(keyword, sc.Keyword.FINAL);
+    bool isConst = node.isConst;
+    bool isFinal = node.isFinal;
     bool hasInitializer = node.initializer != null;
     VariableElementImpl element;
     if (_inFieldContext) {
       SimpleIdentifier fieldName = node.name;
       FieldElementImpl field;
       if (isConst && hasInitializer) {
         field = new ConstFieldElementImpl.con1(fieldName);
       } else {
         field = new FieldElementImpl.forNode(fieldName);
       }
@@ skipping 46 matching lines @@
       initializer.labels = holder.labels;
       initializer.localVariables = holder.localVariables;
       initializer.synthetic = true;
       element.initializer = initializer;
       holder.validate();
     }
     if (element is PropertyInducingElementImpl) {
       PropertyInducingElementImpl variable =
           element as PropertyInducingElementImpl;
       if (_inFieldContext) {
-        (variable as FieldElementImpl).static = _matches(
-            (node.parent.parent as FieldDeclaration).staticKeyword,
-            sc.Keyword.STATIC);
+        (variable as FieldElementImpl).static =
+            (node.parent.parent as FieldDeclaration).isStatic;
       }
       PropertyAccessorElementImpl getter =
           new PropertyAccessorElementImpl.forVariable(variable);
       getter.getter = true;
       _currentHolder.addAccessor(getter);
       variable.getter = getter;
       if (!isConst && !isFinal) {
         PropertyAccessorElementImpl setter =
             new PropertyAccessorElementImpl.forVariable(variable);
         setter.setter = true;
@@ skipping 80 matching lines @@
         return (parent as FunctionExpression).body;
       } else if (parent is MethodDeclaration) {
         return (parent as MethodDeclaration).body;
       }
       parent = parent.parent;
     }
     return null;
   }
 
   /**
-   * Return `true` if the given token is a token for the given keyword.
-   *
-   * @param token the token being tested
-   * @param keyword the keyword being tested for
-   * @return `true` if the given token is a token for the given keyword
-   */
-  bool _matches(sc.Token token, sc.Keyword keyword) =>
-      token != null &&
-          token.type == sc.TokenType.KEYWORD &&
-          (token as sc.KeywordToken).keyword == keyword;
-
-  /**
    * Sets the visible source range for formal parameter.
    */
   void _setParameterVisibleRange(FormalParameter node,
       ParameterElementImpl element) {
     FunctionBody body = _getFunctionBody(node);
     if (body != null) {
       element.setVisibleRange(body.offset, body.length);
     }
   }
 
@@ skipping 12352 matching lines @@
    * library.
    */
   final HashSet<String> members = new HashSet<String>();
 
   /**
    * Names of resolved or unresolved class members that are read in the
    * library.
    */
   final HashSet<String> readMembers = new HashSet<String>();
 }