Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ash/wm/cursor_manager_chromeos.cc

Issue 960073002: Do not hide the cursor on a key up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/ash.gyp ('k') | ash/wm/cursor_manager_chromeos_unittest.cc » ('j') | ash/wm/cursor_manager_chromeos_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/cursor_manager_chromeos.cc
diff --git a/ash/wm/cursor_manager_chromeos.cc b/ash/wm/cursor_manager_chromeos.cc
index 39a74d57034c626b32408244e41386879bf2ad18..af38d5c41f4531e20caaf8d46573903eb5c02f74 100644
--- a/ash/wm/cursor_manager_chromeos.cc
+++ b/ash/wm/cursor_manager_chromeos.cc
@@ -21,6 +21,9 @@ CursorManager::~CursorManager() {
bool CursorManager::ShouldHideCursorOnKeyEvent(
const ui::KeyEvent& event) const {
+ if (event.type() != ui::ET_KEY_PRESSED)
+ return false;
+
// Clicking on a key when the accessibility virtual keyboard is enabled should
// not hide the cursor.
if (keyboard::GetAccessibilityKeyboardEnabled())
« no previous file with comments | « ash/ash.gyp ('k') | ash/wm/cursor_manager_chromeos_unittest.cc » ('j') | ash/wm/cursor_manager_chromeos_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698