Do not hide the cursor on a key up

Do not hide the cursor on a key up

When pressing an accelerator, the user may release the modifier key first.
e.g. press Ctrl, press A, release Ctrl, release A
This CL prevents the cursor from being hidden in this scenario.

BUG=454902
TEST=WindowManagerTest.UpdateCursorVisibilityAccelerator

Committed: https://crrev.com/04be0abc78b0726b72750d4a0b273280c23a30b7
Cr-Commit-Position: refs/heads/master@{#319885}

[pkotwicz, 2015-02-26 02:44:32]

pkotwicz@chromium.org changed reviewers:
+ tdanderson@chromium.org

[pkotwicz, 2015-02-26 02:44:33]

tdanderson@ PTAL

[tdanderson, 2015-02-26 22:21:19]

LGTM

[pkotwicz, 2015-02-26 22:23:03]

pkotwicz@chromium.org changed reviewers:
+ sadrul@chromium.org

[pkotwicz, 2015-02-26 22:23:04]

Sadrul, do you also want to take a look?

[sadrul, 2015-02-26 22:49:27]

LGTM

On linux, if the cursor is in an editable textfield (e.g. omnibox), and the user
presses ctrl, A, then releases ctrl but keep pressing the A key, then the
content of the omnibox gets overwritten, and a stream of 'a' is added to the
textfield. I suspect the behaviour is the same on ChromeOS? If so, then I think
the cursor should be hidden. From what I understand, the cursor will in fact
correctly hide after this change because we should continue to get press-events
if the user does keep pressing the A key. But can you please confirm this before
landing?

https://codereview.chromium.org/960073002/diff/1/ash/wm/cursor_manager_chrome...
File ash/wm/cursor_manager_chromeos_unittest.cc (right):

https://codereview.chromium.org/960073002/diff/1/ash/wm/cursor_manager_chrome...
ash/wm/cursor_manager_chromeos_unittest.cc:1: // Copyright (c) 2012 The Chromium
Authors. All rights reserved.
lol

[pkotwicz, 2015-02-27 16:22:12]

Sadrul, thanks! I did not think of that scenario.
I have confirmed that pressing Ctrl+A and releasing Ctrl puts a stream of 'a's
in the omnibox and hides the cursor

[pkotwicz, 2015-02-27 16:22:14]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-02-27 16:22:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/960073002/#ps20001 (title:
" ")

[commit-bot: I haz the power, 2015-02-27 16:22:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960073002/20001

[commit-bot: I haz the power, 2015-02-27 16:26:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-27 16:26:12]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[pkotwicz, 2015-03-02 00:28:27]

Patchset #3 (id:40001) has been deleted

[pkotwicz, 2015-03-02 01:08:05]

Sadrul, can you please take another look?

I have modified WindowManagerTest.UpdateCursorVisibilityAccelerator and have
moved the new test that WindowManagerTest

[pkotwicz, 2015-03-03 20:41:21]

Sadrul, Ping!

[sadrul, 2015-03-03 20:43:31]

On 2015/03/03 20:41:21, pkotwicz wrote:
> Sadrul, Ping!

LGTM (sorry, I saw my name in green, so I mistakenly assumed you weren't blocked
on my review).

[pkotwicz, 2015-03-04 16:06:11]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-03-04 16:06:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/960073002/#ps60001 (title:
" ")

[commit-bot: I haz the power, 2015-03-04 16:07:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960073002/60001

[commit-bot: I haz the power, 2015-03-04 16:16:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-04 16:16:25]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[pkotwicz, 2015-03-05 16:54:45]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-03-05 16:55:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960073002/60001

[commit-bot: I haz the power, 2015-03-05 18:29:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-05 18:29:03]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2015-03-05 19:16:43]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-03-05 19:18:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960073002/60001

[commit-bot: I haz the power, 2015-03-05 20:44:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-05 20:44:36]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2015-03-05 20:57:23]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-03-05 20:58:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960073002/60001

[commit-bot: I haz the power, 2015-03-05 22:24:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-05 22:24:25]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2015-03-05 22:31:38]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-03-05 22:32:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960073002/60001

[commit-bot: I haz the power, 2015-03-06 00:00:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-06 00:00:14]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2015-03-06 16:05:06]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2015-03-06 16:05:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/960073002/#ps80001 (title:
" ")

[commit-bot: I haz the power, 2015-03-06 16:06:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960073002/80001

[commit-bot: I haz the power, 2015-03-06 17:34:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-06 17:34:29]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2015-03-10 14:47:22]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2015-03-10 14:47:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/960073002/80001

[commit-bot: I haz the power, 2015-03-10 15:38:55]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-03-10 15:39:32]

Patchset 4 (id:??) landed as
https://crrev.com/04be0abc78b0726b72750d4a0b273280c23a30b7
Cr-Commit-Position: refs/heads/master@{#319885}