Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 960033002: Add firewall methods to chromeos::PermissionBrokerClient. (Closed)

Created:
5 years, 9 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 9 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add firewall methods to chromeos::PermissionBrokerClient. This patch adds DBus method wrappers to PermissionBrokerClient for the new Request(Tcp|Udp)PortAccess and Release(Tcp|Udp)Port methods supported by permission_broker. BUG=435404 Committed: https://crrev.com/1e6ff460097c1f069ae16be987459000b9340a5e Cr-Commit-Position: refs/heads/master@{#318186}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Sort using statements lexographically. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -0 lines) Patch
M chromeos/dbus/fake_permission_broker_client.h View 1 chunk +14 lines, -0 lines 0 comments Download
M chromeos/dbus/fake_permission_broker_client.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M chromeos/dbus/permission_broker_client.h View 2 chunks +36 lines, -0 lines 0 comments Download
M chromeos/dbus/permission_broker_client.cc View 1 2 chunks +58 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Reilly Grant (use Gerrit)
Hashimoto-san, please take a look.
5 years, 9 months ago (2015-02-26 01:19:26 UTC) #2
hashimoto
lgtm https://codereview.chromium.org/960033002/diff/1/chromeos/dbus/permission_broker_client.cc File chromeos/dbus/permission_broker_client.cc (right): https://codereview.chromium.org/960033002/diff/1/chromeos/dbus/permission_broker_client.cc#newcode21 chromeos/dbus/permission_broker_client.cc:21: using permission_broker::kReleaseUdpPort; nit: How about sorting these lines ...
5 years, 9 months ago (2015-02-26 03:22:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/960033002/20001
5 years, 9 months ago (2015-02-26 03:38:33 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-26 04:41:58 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 04:42:50 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e6ff460097c1f069ae16be987459000b9340a5e
Cr-Commit-Position: refs/heads/master@{#318186}

Powered by Google App Engine
This is Rietveld 408576698