Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Side by Side Diff: src/opts/SkPMFloat_neon.h

Issue 960023002: Spin off some fixes to land right away. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: try inline instead Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/opts/SkPMFloat_SSE2.h ('k') | src/opts/SkPMFloat_none.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #include "SkColorPriv.h" 1 #include "SkColorPriv.h"
2 #include "SkPMFloat.h"
3 #include <arm_neon.h> 2 #include <arm_neon.h>
4 3
5 // For set(), we widen our 8 bit components (fix8) to 8-bit components in 16 bit s (fix8_16), 4 // For set(), we widen our 8 bit components (fix8) to 8-bit components in 16 bit s (fix8_16),
6 // then widen those to 8-bit-in-32-bits (fix8_32), convert those to floats (scal ed), 5 // then widen those to 8-bit-in-32-bits (fix8_32), convert those to floats (scal ed),
7 // then finally scale those down from [0.0f, 255.0f] to [0.0f, 1.0f] into fColor . 6 // then finally scale those down from [0.0f, 255.0f] to [0.0f, 1.0f] into fColor .
8 7
9 // get() and clamped() do the opposite, working from [0.0f, 1.0f] floats to [0.0 f, 255.0f], 8 // get() and clamped() do the opposite, working from [0.0f, 1.0f] floats to [0.0 f, 255.0f],
10 // to 8-bit-in-32-bit, to 8-bit-in-16-bit, back down to 8-bit components. 9 // to 8-bit-in-32-bit, to 8-bit-in-16-bit, back down to 8-bit components.
11 // clamped() uses vqmovn to clamp while narrowing instead of just narrowing with vmovn. 10 // clamped() uses vqmovn to clamp while narrowing instead of just narrowing with vmovn.
12 11
(...skipping 20 matching lines...) Expand all
33 32
34 inline SkPMColor SkPMFloat::clamped() const { 33 inline SkPMColor SkPMFloat::clamped() const {
35 float32x4_t scaled = vmulq_f32(vld1q_f32(fColor), vdupq_n_f32(255.0f)); 34 float32x4_t scaled = vmulq_f32(vld1q_f32(fColor), vdupq_n_f32(255.0f));
36 uint32x4_t fix8_32 = vcvtq_u32_f32(scaled); 35 uint32x4_t fix8_32 = vcvtq_u32_f32(scaled);
37 uint16x4_t fix8_16 = vqmovn_u32(fix8_32); 36 uint16x4_t fix8_16 = vqmovn_u32(fix8_32);
38 uint8x8_t fix8 = vqmovn_u16(vcombine_u16(fix8_16, vdup_n_u16(0))); 37 uint8x8_t fix8 = vqmovn_u16(vcombine_u16(fix8_16, vdup_n_u16(0)));
39 SkPMColor c = vget_lane_u32((uint32x2_t)fix8, 0); 38 SkPMColor c = vget_lane_u32((uint32x2_t)fix8, 0);
40 SkPMColorAssert(c); 39 SkPMColorAssert(c);
41 return c; 40 return c;
42 } 41 }
OLDNEW
« no previous file with comments | « src/opts/SkPMFloat_SSE2.h ('k') | src/opts/SkPMFloat_none.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698