Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4020)

Unified Diff: chrome/renderer/autofill/password_autofill_manager.h

Issue 9600038: Add Password Autofill Manager to New Autofill (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Adding password popup Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/autofill/password_autofill_manager.h
diff --git a/chrome/renderer/autofill/password_autofill_manager.h b/chrome/renderer/autofill/password_autofill_manager.h
index 254571a89d06645d7f3637a39e23d908999333c4..033bf3eb4a5bd7e3c02279b0673a14a1ea2acd47 100644
--- a/chrome/renderer/autofill/password_autofill_manager.h
+++ b/chrome/renderer/autofill/password_autofill_manager.h
@@ -35,6 +35,9 @@ class PasswordAutofillManager : public content::RenderViewObserver,
// be used for any other autofill activity.
bool TextFieldDidEndEditing(const WebKit::WebInputElement& element);
bool TextDidChangeInTextField(const WebKit::WebInputElement& element);
+ // If using the new Autofill UI that lives in the browser, it will handle
+ // keypresses before this function. This is not currently an issue but if
+ // the keys handled there or here change, this issue may appear.
Ilya Sherman 2012/03/20 00:58:55 nit: Please move this comment inside the implement
csharp 2012/03/21 14:10:31 Done.
bool TextFieldHandlingKeyDown(const WebKit::WebInputElement& element,
const WebKit::WebKeyboardEvent& event);
@@ -75,7 +78,8 @@ class PasswordAutofillManager : public content::RenderViewObserver,
virtual bool InputElementLostFocus() OVERRIDE;
// RenderView IPC handlers:
- void OnFillPasswordForm(const webkit::forms::PasswordFormFillData& form_data);
+ void OnFillPasswordForm(const webkit::forms::PasswordFormFillData& form_data,
+ bool disable_popup);
// Scans the given frame for password forms and sends them up to the browser.
// If |only_visible| is true, only forms visible in the layout are sent.
@@ -114,6 +118,9 @@ class PasswordAutofillManager : public content::RenderViewObserver,
// The logins we have filled so far with their associated info.
LoginToPasswordInfoMap login_to_password_info_;
+ // Used to disable and hide the popup.
+ bool disable_popup_;
+
base::WeakPtrFactory<PasswordAutofillManager> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(PasswordAutofillManager);

Powered by Google App Engine
This is Rietveld 408576698