Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: sky/tests/services/iframe-embed-vmc.sky

Issue 959993002: Dart: Removes name conflicts from generated bindings. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Remove generated toplevel functions Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/tests/services/iframe-embed-vmc.sky
diff --git a/sky/tests/services/iframe-embed-vmc.sky b/sky/tests/services/iframe-embed-vmc.sky
index 1396b0d66d74d2ecbbf5c8fefe7177c64f189334..ed2be2c74cc7aa8b6fb387836aec5de866496f4c 100644
--- a/sky/tests/services/iframe-embed-vmc.sky
+++ b/sky/tests/services/iframe-embed-vmc.sky
@@ -28,8 +28,9 @@ class IFrameEmbed extends Application {
// The Promise returned by the vmcApp's echoString() method will not
// resolve until the vmcApp's onEmbed() method runs.
- final echoService = new echo_service_mojom.EchoServiceProxy.unbound();
- vmcAppConnection.requestService(echoService);
+ final echoServiceProxy = new echo_service_mojom.EchoServiceProxy.unbound();
+ final echoService = echoServiceProxy.interface;
+ vmcAppConnection.requestService(echoServiceProxy);
echoService.echoString("success").then((response) {
internals.notifyTestComplete(response.value);
});
@@ -37,8 +38,8 @@ class IFrameEmbed extends Application {
var applicationPipe = new MojoMessagePipe();
var proxyEndpoint = applicationPipe.endpoints[0];
var applicationEndpoint = applicationPipe.endpoints[1];
- vmcAppConnection.remoteServiceProvider.connectToService(
- view_manager.ViewManagerClient.name, applicationEndpoint);
+ vmcAppConnection.remoteServiceProvider.interface.connectToService(
+ view_manager.ViewManagerClientName, applicationEndpoint);
document.querySelector("iframe").
embedViewManagerClient(proxyEndpoint.handle.h);
}
@@ -47,7 +48,6 @@ class IFrameEmbed extends Application {
main() {
var messagePipe = new MojoMessagePipe();
var app = new IFrameEmbed(messagePipe.endpoints[1]);
- app.listen();
var shellProxy = new shell_mojom.ShellProxy.fromHandle(
new MojoHandle(internals.takeShellProxyHandle()));
app.initializeFromShellProxy(shellProxy, [], "");

Powered by Google App Engine
This is Rietveld 408576698