Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 959983002: Add filter function to gpu_times. (Closed)

Created:
5 years, 10 months ago by David Yen
Modified:
5 years, 10 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add filter function to gpu_times. In order to prepare for future changes where additional metrics will be added to the TBM module, I have also preemptively added a filter function which filters out values relating to gpu_times. R=nednguyen@chromium.org BUG=455292, 453131 Committed: https://crrev.com/7984b4ad04d0e3f9e4d4881056eec9721fd53f5d Cr-Commit-Position: refs/heads/master@{#318154}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
M tools/perf/benchmarks/gpu_times.py View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/metrics/gpu_timeline.py View 2 chunks +23 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
David Yen
5 years, 10 months ago (2015-02-25 23:09:44 UTC) #1
David Yen
Partial revert of the previous CL revert, keep tests disabled.
5 years, 10 months ago (2015-02-25 23:10:18 UTC) #3
nednguyen
lgtm
5 years, 10 months ago (2015-02-25 23:29:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959983002/1
5 years, 10 months ago (2015-02-25 23:31:57 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 00:19:39 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 00:20:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7984b4ad04d0e3f9e4d4881056eec9721fd53f5d
Cr-Commit-Position: refs/heads/master@{#318154}

Powered by Google App Engine
This is Rietveld 408576698