remoting/webapp/unittests/ipc_unittest.js - Issue 959963002: [Chromoting] Enable jscompile for webapp unittests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/webapp/unittests/ipc_unittest.js

Issue 959963002: [Chromoting] Enable jscompile for webapp unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename sinon.$testStub -> sinon.TestStub Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/webapp/unittests/ipc_unittest.js

diff --git a/remoting/webapp/unittests/ipc_unittest.js b/remoting/webapp/unittests/ipc_unittest.js

index 9434cabe97c3adcc2aa5dfaf37aac2c54f6b9173..e786147e50933e2f64e4e70155cbb72b0d6f3644 100644

--- a/remoting/webapp/unittests/ipc_unittest.js

+++ b/remoting/webapp/unittests/ipc_unittest.js

@@ -6,6 +6,7 @@

'use strict';

+/** @type {base.Ipc} */

var ipc_;

function pass() {

@@ -62,7 +63,7 @@ QUnit.asyncTest(

function() {

var handler = sinon.spy();

ipc_.register('foo', handler);

- ipc_.unregister('foo', handler);

+ ipc_.unregister('foo');

base.Ipc.invoke('foo', 'hello', 'world').then(fail, function(error) {

sinon.assert.notCalled(handler);

QUnit.equal(error, base.Ipc.Error.UNSUPPORTED_REQUEST_TYPE);