Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: remoting/webapp/unittests/event_hook_unittest.js

Issue 959963002: [Chromoting] Enable jscompile for webapp unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix key tester Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/unittests/event_hook_unittest.js
diff --git a/remoting/webapp/unittests/event_hook_unittest.js b/remoting/webapp/unittests/event_hook_unittest.js
index ee67d1f4a300a5b3174352627f159cc350a1c118..15135bdee045f0577ade2fc9ae6805f352d38537 100644
--- a/remoting/webapp/unittests/event_hook_unittest.js
+++ b/remoting/webapp/unittests/event_hook_unittest.js
@@ -2,19 +2,40 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+/**
+ * @fileoverview
+ * TODO(garykac) Remove suppression once chromeMocks has been replaced.
+ * @suppress {checkTypes|checkVars|reportUnknownTypes}
+ */
+
(function() {
'use strict';
+/** @type {base.EventSourceImpl} */
var eventSource = null;
+
+/** @type {HTMLElement} */
var domElement = null;
+
+/** @type {chromeMocks.Event} */
var myChromeEvent = null;
+
+/** @type {Listener} */
var listener = null;
+/**
+ * @param {HTMLElement} element
+ * @constructor
+ */
var Listener = function(element) {
- this.onChromeEvent = sinon.stub();
- this.onClickEvent = sinon.stub();
- this.onCustomEvent = sinon.stub();
+ /** @type {(sinon.Spy|function(...?))} */
+ this.onChromeEvent = sinon.spy();
+ /** @type {(sinon.Spy|function(...?))} */
+ this.onClickEvent = sinon.spy();
+ /** @type {(sinon.Spy|function(...?))} */
+ this.onCustomEvent = sinon.spy();
+
this.eventHooks_ = new base.Disposables(
new base.DomEventHook(element, 'click', this.onClickEvent.bind(this),
false),
@@ -35,7 +56,7 @@ function raiseAllEvents() {
module('base.EventHook', {
setup: function() {
- domElement = document.createElement('div');
+ domElement = /** @type {HTMLElement} */ (document.createElement('div'));
eventSource = new base.EventSourceImpl();
eventSource.defineEvents(['customEvent']);
myChromeEvent = new chromeMocks.Event();

Powered by Google App Engine
This is Rietveld 408576698