Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: remoting/webapp/unittests/l10n_unittest.js

Issue 959963002: [Chromoting] Enable jscompile for webapp unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/unittests/l10n_unittest.js
diff --git a/remoting/webapp/unittests/l10n_unittest.js b/remoting/webapp/unittests/l10n_unittest.js
index 6ac3680f7599228447419dae8ee02f16ef2fd341..043aaabc8a7131de0e5eccb56ad9a2b0973401af 100644
--- a/remoting/webapp/unittests/l10n_unittest.js
+++ b/remoting/webapp/unittests/l10n_unittest.js
@@ -8,10 +8,10 @@
module('l10n', {
setup: function() {
- sinon.stub(chrome.i18n, 'getMessage');
+ sinon.$setupStub(chrome.i18n, 'getMessage');
},
teardown: function() {
- chrome.i18n.getMessage.restore();
+ chrome.i18n.getMessage.$testStub.restore();
}
});
@@ -23,7 +23,8 @@ test('getTranslationOrError(tag) should return tag on error', function() {
test('localizeElementFromTag() should replace innerText by default',
function() {
var element = document.createElement('div');
- chrome.i18n.getMessage.withArgs('tag').returns('<b>Hello World</b>');
+ chrome.i18n.getMessage.$testStub.withArgs('tag')
+ .returns('<b>Hello World</b>');
l10n.localizeElementFromTag(element, 'tag');
@@ -33,7 +34,8 @@ test('localizeElementFromTag() should replace innerText by default',
test('localizeElementFromTag() should replace innerHTML if flag is set',
function() {
var element = document.createElement('div');
- chrome.i18n.getMessage.withArgs('tag').returns('<b>Hello World</b>');
+ chrome.i18n.getMessage.$testStub.withArgs('tag')
+ .returns('<b>Hello World</b>');
l10n.localizeElementFromTag(element, 'tag', null, true);
@@ -46,7 +48,8 @@ test(
function() {
var element = document.createElement('div');
element.setAttribute('i18n-content', 'tag');
- chrome.i18n.getMessage.withArgs('tag').returns('<b>Hello World</b>');
+ chrome.i18n.getMessage.$testStub.withArgs('tag')
+ .returns('<b>Hello World</b>');
l10n.localizeElement(element);
@@ -59,7 +62,7 @@ test(
function() {
var fixture = document.getElementById('qunit-fixture');
fixture.innerHTML = '<div class="target" i18n-title="tag"></div>';
- chrome.i18n.getMessage.withArgs('tag').returns('localized title');
+ chrome.i18n.getMessage.$testStub.withArgs('tag').returns('localized title');
l10n.localize();
@@ -76,7 +79,7 @@ test('localize() should support string substitutions', function() {
'i18n-value-2="param2">' +
'</div>';
- chrome.i18n.getMessage.withArgs('tag', ['param1', 'param2'])
+ chrome.i18n.getMessage.$testStub.withArgs('tag', ['param1', 'param2'])
.returns('localized');
l10n.localize();
@@ -91,7 +94,7 @@ test('localize() should support tag substitutions', function() {
'<div class="target" i18n-content="tag"' +
' i18n-value-name-1="tag1" i18n-value-name-2="tag2"></div>';
- var getMessage = chrome.i18n.getMessage;
+ var getMessage = chrome.i18n.getMessage.$testStub;
getMessage.withArgs('tag1').returns('param1');
getMessage.withArgs('tag2').returns('param2');
getMessage.withArgs('tag', ['param1', 'param2']).returns('localized');

Powered by Google App Engine
This is Rietveld 408576698