[Chromoting] Enable jscompile for webapp unittests.

remoting/webapp/unittests/ipc_unittest.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function() {
 
 'use strict';
 
+/** @type {base.Ipc} */
 var ipc_;
 
 function pass() {
   ok(true);
   QUnit.start();
 }
 
 function fail() {
   ok(false);
   QUnit.start();
 }
 
 module('base.Ipc', {
   setup: function() {
-    chromeMocks.activate(['runtime']);
     ipc_ = base.Ipc.getInstance();
   },
   teardown: function() {
     base.Ipc.deleteInstance();
     ipc_ = null;
-    chromeMocks.restore();
   }
 });
 
 QUnit.test(
   'register() should return false if the request type was already registered',
   function() {
+    /** @type {function(...?)} */
     var handler1 = function() {};
+    /** @type {function(...?)} */
     var handler2 = function() {};
     QUnit.equal(true, ipc_.register('foo', handler1));
     QUnit.equal(false, ipc_.register('foo', handler2));
 });
 
 QUnit.asyncTest(
   'send() should invoke a registered handler with the correct arguments',
   function() {
-    var handler = sinon.spy();
+    var handler = /** @type {function(...?)} */ (sinon.spy());

[kelvinp, 2015/02/26 00:31:30]

You can simply change the definition ipc.js to be Function and that would saves
you all the modifications in this file other than setup on the top.

[garykac, 2015/02/28 02:33:33]

Done.

     var argArray = [1, 2, 3];
     var argDict = {
       key1: 'value1',
       key2: false
     };
 
     ipc_.register('foo', handler);
     base.Ipc.invoke('foo', 1, false, 'string', argArray, argDict).then(
       function() {
         sinon.assert.calledWith(handler, 1, false, 'string', argArray, argDict);
         pass();
     }, fail);
 });
 
 QUnit.asyncTest(
   'send() should not invoke a handler that is unregistered',
   function() {
-    var handler = sinon.spy();
+    var handler = /** @type {function(...?)} */ (sinon.spy());
     ipc_.register('foo', handler);
-    ipc_.unregister('foo', handler);
+    ipc_.unregister('foo');
     base.Ipc.invoke('foo', 'hello', 'world').then(fail, function(error) {
       sinon.assert.notCalled(handler);
       QUnit.equal(error, base.Ipc.Error.UNSUPPORTED_REQUEST_TYPE);
       pass();
     });
 });
 
 QUnit.asyncTest(
   'send() should raise exceptions on unknown request types',
   function() {
-    var handler = sinon.spy();
+    var handler = /** @type {function(...?)} */ (sinon.spy());
     ipc_.register('foo', handler);
     base.Ipc.invoke('bar', 'hello', 'world').then(fail, function(error) {
       QUnit.equal(error, base.Ipc.Error.UNSUPPORTED_REQUEST_TYPE);
       pass();
     });
 });
 
 QUnit.asyncTest(
   'send() should raise exceptions on request from another extension',
   function() {
-    var handler = sinon.spy();
+    var handler = /** @type {function(...?)} */ (sinon.spy());
     var oldId = chrome.runtime.id;
     ipc_.register('foo', handler);
     chrome.runtime.id = 'foreign-extension';
     base.Ipc.invoke('foo', 'hello', 'world').then(fail, function(error) {
       QUnit.equal(error, base.Ipc.Error.INVALID_REQUEST_ORIGIN);
       pass();
     });
     chrome.runtime.id = oldId;
 });
 
@@ skipping 32 matching lines @@
       QUnit.equal(results[0], false);
       QUnit.equal(results[1], 12);
       QUnit.equal(results[2], 'string');
       QUnit.deepEqual(results[3], [1,2]);
       QUnit.deepEqual(results[4], {key1: 'value1', key2: 'value2'});
       pass();
     }, fail);
 });
 
 })();