[Chromoting] Enable jscompile for webapp unittests.

remoting/remoting_webapp_files.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'remoting_webapp_info_files': [
       'resources/chromoting16.webp',
       'resources/chromoting48.webp',
       'resources/chromoting128.webp',
     ],
 
     # Jscompile proto files.
     # These provide type information for jscompile.
     'remoting_webapp_js_proto_files': [
       'webapp/js_proto/chrome_proto.js',
+      'webapp/js_proto/chrome_cast_proto.js',
+      'webapp/js_proto/chrome_event_proto.js',
       'webapp/js_proto/dom_proto.js',
       'webapp/js_proto/remoting_proto.js',
-      'webapp/js_proto/test_proto.js',
     ],
 
     #
-    # Webapp browsertest and unittest JavaScript files.
+    # Webapp browsertest JavaScript files.
     #
 
-    # Shared files for tests.
-    'remoting_webapp_test_js_common_files': [
-      'webapp/unittests/mock_signal_strategy.js',
-    ],
     # Browser test files.
     'remoting_webapp_browsertest_js_files': [
       'webapp/browser_test/browser_test.js',
       'webapp/browser_test/bump_scroll_browser_test.js',
       'webapp/browser_test/cancel_pin_browser_test.js',
       'webapp/browser_test/invalid_pin_browser_test.js',
       'webapp/browser_test/it2me_browser_test.js',
+      'webapp/browser_test/scrollbar_browser_test.js',
+      'webapp/browser_test/timeout_waiter.js',
+      'webapp/browser_test/unauthenticated_browser_test.js',
+      'webapp/browser_test/update_pin_browser_test.js',
+    ],
+    # Browser test files.
+    'remoting_webapp_browsertest_js_mock_files': [
       'webapp/browser_test/mock_client_plugin.js',
       'webapp/browser_test/mock_host_list_api.js',
       'webapp/browser_test/mock_identity.js',
       'webapp/browser_test/mock_oauth2_api.js',
       'webapp/browser_test/mock_session_connector.js',
-      'webapp/browser_test/scrollbar_browser_test.js',
-      'webapp/browser_test/timeout_waiter.js',
-      'webapp/browser_test/unauthenticated_browser_test.js',
-      'webapp/browser_test/update_pin_browser_test.js',
+      'webapp/unittests/mock_signal_strategy.js',
+    ],
+    'remoting_webapp_browsertest_js_proto_files': [
+      'webapp/js_proto/sinon_proto.js',
+      'webapp/js_proto/test_proto.js',
+      '<@(remoting_webapp_js_proto_files)',
     ],
     'remoting_webapp_browsertest_all_js_files': [
       '<@(remoting_webapp_browsertest_js_files)',
-      '<@(remoting_webapp_test_js_common_files)',
+      '<@(remoting_webapp_browsertest_js_mock_files)',
     ],
 
+    #
+    # Webapp unittest JavaScript files.
+    #
+
     # These product files are excluded from our JavaScript unittest
     'remoting_webapp_unittest_exclude_js_files': [
       # background.js is where the onLoad handler is defined, which
       # makes it the entry point of the background page.
       'webapp/crd/js/background.js',
     ],
     # The unit test cases for the webapp
     'remoting_webapp_unittest_js_files': [
-      'webapp/unittests/chrome_mocks.js',
-      'webapp/js_proto/chrome_proto.js',
       'webapp/unittests/apps_v2_migration_unittest.js',
       'webapp/unittests/base_unittest.js',
       'webapp/unittests/desktop_viewport_unittest.js',
       'webapp/unittests/dns_blackhole_checker_unittest.js',
       'webapp/unittests/event_hook_unittest.js',
       'webapp/unittests/fallback_signal_strategy_unittest.js',
       'webapp/unittests/ipc_unittest.js',
       'webapp/unittests/it2me_helpee_channel_unittest.js',
       'webapp/unittests/it2me_helper_channel_unittest.js',
       'webapp/unittests/it2me_service_unittest.js',
       'webapp/unittests/l10n_unittest.js',
       'webapp/unittests/menu_button_unittest.js',
       'webapp/unittests/xmpp_connection_unittest.js',
       'webapp/unittests/xmpp_login_handler_unittest.js',
       'webapp/unittests/xmpp_stream_parser_unittest.js',
     ],
+    'remoting_webapp_unittest_js_mock_files': [
+      # Some proto files can be repurposed as simple mocks for the unittests.
+      # Note that some defs in chrome_proto are overwritten by chrome_mocks.
+      'webapp/js_proto/chrome_proto.js',

[kelvinp, 2015/02/26 00:31:30]

I thought we are getting rid of chrome_proto.js

[garykac, 2015/02/28 02:33:33]

I removed the parts that needed to be moved out, but the majority of it would be
identical between the proto and the mock, so I left it for now.

+      'webapp/unittests/chrome_mocks.js',
+      'webapp/unittests/mock_signal_strategy.js',
+      'webapp/unittests/sinon_helpers.js',
+      'webapp/unittests/test_start.js',
+    ],
+    # Prototypes for objects that are not mocked.
+    'remoting_webapp_unittest_js_proto_files': [
+      'webapp/js_proto/chrome_cast_proto.js',
+      'webapp/js_proto/dom_proto.js',
+      'webapp/js_proto/remoting_proto.js',
+      'webapp/js_proto/qunit_proto.js',
+      'webapp/js_proto/sinon_proto.js',
+      'webapp/js_proto/sinon_stub_proto.js',
+    ],
     'remoting_webapp_unittest_all_js_files': [
       '<@(remoting_webapp_unittest_js_files)',
-      '<@(remoting_webapp_test_js_common_files)',
+      '<@(remoting_webapp_unittest_js_mock_files)',
     ],
+    # All the files needed to run the unittests.
     'remoting_webapp_unittest_all_files': [
       'webapp/crd/html/menu_button.css',
       '<@(remoting_webapp_unittest_all_js_files)',
     ],
     'remoting_webapp_unittest_template_main':
       'webapp/crd/html/template_unittest.html',
 
     #
     # Webapp JavaScript file groups.
     #
@@ skipping 300 matching lines @@
       'webapp/crd/manifest.json.jinja2',
       '<(remoting_webapp_template_main)',
       '<(remoting_webapp_template_wcs_sandbox)',
       '<(remoting_webapp_template_background)',
       '<@(remoting_webapp_template_files)',
       '<@(remoting_webapp_crd_js_files)',
     ],
 
   },
 }