Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(863)

Unified Diff: ui/ozone/platform/dri/dri_window_delegate_impl.cc

Issue 959953002: [Ozone-Dri] Do not call AddFramebuffer with cursor buffers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/ozone/platform/dri/dri_surface_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/ozone/platform/dri/dri_window_delegate_impl.cc
diff --git a/ui/ozone/platform/dri/dri_window_delegate_impl.cc b/ui/ozone/platform/dri/dri_window_delegate_impl.cc
index 0ebd524b453571c82f08d4256305bd48ee0160ba..d948321a1b66fe96291c6e54422aa81b7baa56c0 100644
--- a/ui/ozone/platform/dri/dri_window_delegate_impl.cc
+++ b/ui/ozone/platform/dri/dri_window_delegate_impl.cc
@@ -74,7 +74,11 @@ void DriWindowDelegateImpl::Initialize() {
SkImageInfo info = SkImageInfo::MakeN32Premul(cursor_width, cursor_height);
for (size_t i = 0; i < arraysize(cursor_buffers_); ++i) {
cursor_buffers_[i] = new DriBuffer(drm);
- if (!cursor_buffers_[i]->Initialize(info)) {
+ // Don't register a framebuffer for cursors since they are special (they
+ // aren't modesetting buffers and drivers may fail to register them due to
+ // their small sizes).
+ if (!cursor_buffers_[i]->Initialize(
+ info, false /* should_register_framebuffer */)) {
LOG(ERROR) << "Failed to initialize cursor buffer";
return;
}
« no previous file with comments | « ui/ozone/platform/dri/dri_surface_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698