[Ozone-Dri] Do not call AddFramebuffer with cursor buffers

ui/ozone/platform/dri/dri_buffer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/dri/dri_buffer.h"
 
 #include "base/logging.h"
 #include "ui/ozone/platform/dri/dri_wrapper.h"
 
 namespace ui {
@@ skipping 35 matching lines @@
     dri_->RemoveFramebuffer(framebuffer_);
 
   SkImageInfo info;
   void* pixels = const_cast<void*>(surface_->peekPixels(&info, NULL));
   if (!pixels)
     return;
 
   dri_->DestroyDumbBuffer(info, handle_, stride_, pixels);
 }
 
-bool DriBuffer::Initialize(const SkImageInfo& info) {
+bool DriBuffer::Initialize(const SkImageInfo& info, bool is_scanout) {
   void* pixels = NULL;
   if (!dri_->CreateDumbBuffer(info, &handle_, &stride_, &pixels)) {
     VLOG(2) << "Cannot create drm dumb buffer";
     return false;
   }
 
-  if (!dri_->AddFramebuffer(info.width(),
-                            info.height(),
-                            GetColorDepth(info.colorType()),
-                            info.bytesPerPixel() << 3,
-                            stride_,
-                            handle_,
-                            &framebuffer_)) {
+  if (is_scanout &&
+      !dri_->AddFramebuffer(
+          info.width(), info.height(), GetColorDepth(info.colorType()),
+          info.bytesPerPixel() << 3, stride_, handle_, &framebuffer_)) {

[spang, 2015/02/25 22:30:01]

Can you move this to a 2nd function?

[dnicoara, 2015/02/25 22:48:56]

Why do you want to split it in another function? It adds no value and makes the
initialization process more complicated.

     VLOG(2) << "Failed to register framebuffer: " << strerror(errno);
     return false;
   }
 
   surface_ = skia::AdoptRef(SkSurface::NewRasterDirect(info, pixels, stride_));
   if (!surface_) {
     VLOG(2) << "Cannot install Skia pixels for drm buffer";
     return false;
   }
 
@@ skipping 19 matching lines @@
 DriBufferGenerator::DriBufferGenerator() {
 }
 
 DriBufferGenerator::~DriBufferGenerator() {}
 
 scoped_refptr<ScanoutBuffer> DriBufferGenerator::Create(
     const scoped_refptr<DriWrapper>& drm,
     const gfx::Size& size) {
   scoped_refptr<DriBuffer> buffer(new DriBuffer(drm));
   SkImageInfo info = SkImageInfo::MakeN32Premul(size.width(), size.height());
-  if (!buffer->Initialize(info))
+  if (!buffer->Initialize(info, true))
     return NULL;
 
   return buffer;
 }
 
 }  // namespace ui