Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: core/editing/Selection.idl

Issue 959933002: Move IDLs to 39 roll (Closed) Base URL: https://dart.googlecode.com/svn/third_party/WebCore
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/dom/Range.idl ('k') | core/events/EventTarget.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/editing/Selection.idl
diff --git a/core/editing/Selection.idl b/core/editing/Selection.idl
index dc27b0d9bfbe2d06112f4fcaed18e339ecad9d87..263a3c2b8e93c7e002f5e10378aeb567b554c4a2 100644
--- a/core/editing/Selection.idl
+++ b/core/editing/Selection.idl
@@ -45,14 +45,13 @@
readonly attribute long focusOffset;
readonly attribute boolean isCollapsed;
- [RaisesException, TypeChecking=Interface] void collapse(Node node, optional long offset);
+ [RaisesException] void collapse(Node? node, optional long offset = 0);
[RaisesException] void collapseToStart();
[RaisesException] void collapseToEnd();
- // FIXME: should be: optional long offset = 0 http://crbug.com/258153
// We mark offset as optional, defaulting to 0; this differs from spec.
// http://crbug.com/384966
- [RaisesException, TypeChecking=Interface] void extend(Node node, optional long offset);
+ [RaisesException, TypeChecking=Interface] void extend(Node node, optional long offset = 0);
[RaisesException] void selectAllChildren([Default=Undefined] optional Node node);
[CustomElementCallbacks] void deleteFromDocument();
@@ -67,8 +66,7 @@
// Firefox extensions
// https://developer.mozilla.org/En/DOM/Selection
//
- // FIXME: Add use counters.
- boolean containsNode([Default = Undefined] optional Node node, [Default = Undefined] optional boolean allowPartial);
+ [MeasureAs=SelectionContainsNode] boolean containsNode([Default = Undefined] optional Node node, [Default = Undefined] optional boolean allowPartial);
// WebKit extensions
[MeasureAs=SelectionBaseNode] readonly attribute Node baseNode;
@@ -87,8 +85,7 @@
[Default=Undefined] optional long baseOffset,
[Default=Undefined] optional Node extentNode,
[Default=Undefined] optional long extentOffset);
- [ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException, TypeChecking=Interface] void setPosition(Node node,
- optional long offset);
+ [ImplementedAs=collapse, MeasureAs=SelectionSetPosition, RaisesException] void setPosition(Node? node, optional long offset = 0);
// IE extensions
// http://msdn.microsoft.com/en-us/library/ms535869(VS.85).aspx
« no previous file with comments | « core/dom/Range.idl ('k') | core/events/EventTarget.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698