Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Side by Side Diff: bindings/dart/scripts/dart_dictionary.py

Issue 959933002: Move IDLs to 39 roll (Closed) Base URL: https://dart.googlecode.com/svn/third_party/WebCore
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « bindings/dart/scripts/dart_compiler.py ('k') | bindings/dart/scripts/dart_interface.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Generate template contexts of dictionaries for both v8 bindings and 5 """Generate template contexts of dictionaries for both v8 bindings and
6 implementation classes that are used by blink's core/modules. 6 implementation classes that are used by blink's core/modules.
7 """ 7 """
8 8
9 import copy
10 import operator 9 import operator
11 from v8_globals import includes 10 from v8_globals import includes
12 import v8_types 11 import dart_types
13 import v8_utilities 12 from dart_utilities import DartUtilities
14 13
15 14
16 DICTIONARY_H_INCLUDES = frozenset([ 15 DICTIONARY_H_INCLUDES = frozenset([
17 'bindings/core/v8/V8Binding.h', 16 'bindings/core/v8/V8Binding.h',
18 'platform/heap/Handle.h', 17 'platform/heap/Handle.h',
19 ]) 18 ])
20 19
21 DICTIONARY_CPP_INCLUDES = frozenset([ 20 DICTIONARY_CPP_INCLUDES = frozenset([
21 'bindings/common/ExceptionState.h',
22 # FIXME: Remove this, http://crbug.com/321462 22 # FIXME: Remove this, http://crbug.com/321462
23 'bindings/core/v8/Dictionary.h', 23 'bindings/core/v8/Dictionary.h',
24 ]) 24 ])
25 25
26 26
27 def setter_name_for_dictionary_member(member): 27 def setter_name_for_dictionary_member(member):
28 return 'set%s' % v8_utilities.capitalize(member.name) 28 return 'set%s' % DartUtilities.capitalize(member.name)
29 29
30 30
31 def has_method_name_for_dictionary_member(member): 31 def has_method_name_for_dictionary_member(member):
32 return 'has%s' % v8_utilities.capitalize(member.name) 32 return 'has%s' % DartUtilities.capitalize(member.name)
33 33
34 34
35 # Context for V8 bindings 35 def unwrap_nullable_if_needed(idl_type):
36 if idl_type.is_nullable:
37 return idl_type.inner_type
38 return idl_type
39
40
41 # Context for Dart bindings
36 42
37 def dictionary_context(dictionary): 43 def dictionary_context(dictionary):
38 includes.clear() 44 includes.clear()
39 includes.update(DICTIONARY_CPP_INCLUDES) 45 includes.update(DICTIONARY_CPP_INCLUDES)
40 return { 46 return {
41 'cpp_class': v8_utilities.cpp_name(dictionary), 47 'cpp_class': DartUtilities.cpp_name(dictionary),
42 'header_includes': set(DICTIONARY_H_INCLUDES), 48 'header_includes': set(DICTIONARY_H_INCLUDES),
43 'members': [member_context(member) 49 'members': [member_context(member)
44 for member in sorted(dictionary.members, 50 for member in sorted(dictionary.members,
45 key=operator.attrgetter('name'))], 51 key=operator.attrgetter('name'))],
46 'v8_class': v8_utilities.v8_class_name(dictionary), 52 'dart_class': dart_types.dart_type(dictionary.name),
53
47 } 54 }
48 55
49 56
50 def member_context(member): 57 def member_context(member):
51 idl_type = member.idl_type 58 idl_type = member.idl_type
52 idl_type.add_includes_for_type() 59 idl_type.add_includes_for_type()
53 60 idl_type = unwrap_nullable_if_needed(idl_type)
54 def idl_type_for_default_value():
55 copied_type = copy.copy(idl_type)
56 # IdlType for default values shouldn't be nullable. Otherwise,
57 # it will generate meaningless expression like
58 # 'String("default value").isNull() ? ...'.
59 copied_type.is_nullable = False
60 return copied_type
61 61
62 def default_values(): 62 def default_values():
63 if not member.default_value: 63 if not member.default_value:
64 return None, None 64 return None, None
65 if member.default_value.is_null: 65 if member.default_value.is_null:
66 return None, 'v8::Null(isolate)' 66 return None, 'v8::Null(isolate)'
67 cpp_default_value = str(member.default_value) 67 cpp_default_value = str(member.default_value)
68 v8_default_value = idl_type_for_default_value().cpp_value_to_v8_value( 68 v8_default_value = idl_type.cpp_value_to_v8_value(
69 cpp_value=cpp_default_value, isolate='isolate', 69 cpp_value=cpp_default_value, isolate='isolate',
70 creation_context='creationContext') 70 creation_context='creationContext')
71 return cpp_default_value, v8_default_value 71 return cpp_default_value, v8_default_value
72 72
73 cpp_default_value, v8_default_value = default_values() 73 cpp_default_value, dart_default_value = default_values()
74
75 dart_enum_expression = idl_type.enum_validation_expression
76 if dart_enum_expression:
77 dart_enum_expression = dart_enum_expression.format(param_name='string')
74 78
75 return { 79 return {
76 'cpp_default_value': cpp_default_value, 80 'cpp_default_value': cpp_default_value,
77 'cpp_type': idl_type.cpp_type, 81 'cpp_type': idl_type.cpp_type,
78 'cpp_value_to_v8_value': idl_type.cpp_value_to_v8_value( 82 'cpp_value_to_dart_value': idl_type.cpp_value_to_dart_value(
79 cpp_value='impl->%s()' % member.name, isolate='isolate', 83 cpp_value='impl->%s()' % member.name,
80 creation_context='creationContext', 84 creation_context='creationContext',
81 extended_attributes=member.extended_attributes), 85 extended_attributes=member.extended_attributes),
86 'enum_validation_expression': dart_enum_expression,
82 'has_method_name': has_method_name_for_dictionary_member(member), 87 'has_method_name': has_method_name_for_dictionary_member(member),
88 'is_object': idl_type.name == 'Object',
83 'name': member.name, 89 'name': member.name,
84 'setter_name': setter_name_for_dictionary_member(member), 90 'setter_name': setter_name_for_dictionary_member(member),
85 'v8_default_value': v8_default_value, 91 'dart_default_value': dart_default_value,
86 } 92 }
87 93
88 94
89 # Context for implementation classes 95 # Context for implementation classes
90 96
91 def dictionary_impl_context(dictionary, interfaces_info): 97 def dictionary_impl_context(dictionary, interfaces_info):
92 includes.clear() 98 includes.clear()
93 header_includes = set(['platform/heap/Handle.h']) 99 header_includes = set(['platform/heap/Handle.h'])
94 return { 100 return {
95 'header_includes': header_includes, 101 'header_includes': header_includes,
96 'cpp_class': v8_utilities.cpp_name(dictionary), 102 'cpp_class': DartUtilities.cpp_name(dictionary),
97 'members': [member_impl_context(member, interfaces_info, 103 'members': [member_impl_context(member, interfaces_info,
98 header_includes) 104 header_includes)
99 for member in dictionary.members], 105 for member in dictionary.members],
100 } 106 }
101 107
102 108
103 def member_impl_context(member, interfaces_info, header_includes): 109 def member_impl_context(member, interfaces_info, header_includes):
104 idl_type = member.idl_type 110 idl_type = unwrap_nullable_if_needed(member.idl_type)
111 is_object = idl_type.name == 'Object'
105 112
106 def getter_expression(): 113 def getter_expression():
107 if idl_type.impl_should_use_nullable_container: 114 if idl_type.impl_should_use_nullable_container:
108 return 'm_%s.get()' % member.name 115 return 'm_%s.get()' % member.name
109 return 'm_%s' % member.name 116 return 'm_%s' % member.name
110 117
111 def has_method_expression(): 118 def has_method_expression():
112 if (idl_type.impl_should_use_nullable_container or 119 if idl_type.impl_should_use_nullable_container or idl_type.is_enum or id l_type.is_string_type:
113 idl_type.is_string_type):
114 return '!m_%s.isNull()' % member.name 120 return '!m_%s.isNull()' % member.name
121 elif is_object:
122 return '!(m_{0}.isEmpty() || m_{0}.isNull() || m_{0}.isUndefined())' .format(member.name)
115 else: 123 else:
116 return 'm_%s' % member.name 124 return 'm_%s' % member.name
117 125
118 def member_cpp_type(): 126 def member_cpp_type():
119 member_cpp_type = idl_type.cpp_type_args(used_in_cpp_sequence=True) 127 member_cpp_type = idl_type.cpp_type_args(used_in_cpp_sequence=True)
120 if idl_type.impl_should_use_nullable_container: 128 if idl_type.impl_should_use_nullable_container:
121 return v8_types.cpp_template_type('Nullable', member_cpp_type) 129 return dart_types.cpp_template_type('Nullable', member_cpp_type)
122 return member_cpp_type 130 return member_cpp_type
123 131
132 cpp_default_value = None
133 if member.default_value and not member.default_value.is_null:
134 cpp_default_value = str(member.default_value)
135
124 header_includes.update(idl_type.impl_includes_for_type(interfaces_info)) 136 header_includes.update(idl_type.impl_includes_for_type(interfaces_info))
125 return { 137 return {
138 'cpp_default_value': cpp_default_value,
126 'getter_expression': getter_expression(), 139 'getter_expression': getter_expression(),
127 'has_method_expression': has_method_expression(), 140 'has_method_expression': has_method_expression(),
128 'has_method_name': has_method_name_for_dictionary_member(member), 141 'has_method_name': has_method_name_for_dictionary_member(member),
142 'is_object': is_object,
129 'is_traceable': (idl_type.is_garbage_collected or 143 'is_traceable': (idl_type.is_garbage_collected or
130 idl_type.is_will_be_garbage_collected), 144 idl_type.is_will_be_garbage_collected),
131 'member_cpp_type': member_cpp_type(), 145 'member_cpp_type': member_cpp_type(),
132 'name': member.name, 146 'name': member.name,
133 'rvalue_cpp_type': idl_type.cpp_type_args(used_as_rvalue_type=True), 147 'rvalue_cpp_type': idl_type.cpp_type_args(used_as_rvalue_type=True),
134 'setter_name': setter_name_for_dictionary_member(member), 148 'setter_name': setter_name_for_dictionary_member(member),
135 } 149 }
OLDNEW
« no previous file with comments | « bindings/dart/scripts/dart_compiler.py ('k') | bindings/dart/scripts/dart_interface.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698