Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: chrome/browser/chromeos/events/event_rewriter.cc

Issue 959923002: Fix CapsLock remapping. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/events/event_rewriter.cc
diff --git a/chrome/browser/chromeos/events/event_rewriter.cc b/chrome/browser/chromeos/events/event_rewriter.cc
index b0b8531d9c45aa7a163dd4718b60bf83e0102d2d..f091b60b7f669332291fa2958e39ae84d1223970 100644
--- a/chrome/browser/chromeos/events/event_rewriter.cc
+++ b/chrome/browser/chromeos/events/event_rewriter.cc
@@ -637,11 +637,12 @@ void EventRewriter::RewriteModifierKeys(const ui::KeyEvent& key_event,
current_diamond_key_modifier_flags_ = ui::EF_NONE;
}
break;
- // On Chrome OS, XF86XK_Launch7 (F16) with Mod3Mask is sent when Caps Lock
- // is pressed (with one exception: when
+ // On X11 Chrome OS, XF86XK_Launch7 (F16) with Mod3Mask is sent when Caps
+ // Lock is pressed (with one exception: when
// IsISOLevel5ShiftUsedByCurrentInputMethod() is true, the key generates
// XK_ISO_Level3_Shift with Mod3Mask, not XF86XK_Launch7).
Daniel Erat 2015/02/25 22:13:45 does this comment need to be updated to describe w
kpschoedel 2015/02/25 23:03:06 Using spang's suggestion & removing this file from
case ui::VKEY_F16:
+ case ui::VKEY_CAPITAL:
characteristic_flag = ui::EF_CAPS_LOCK_DOWN;
remapped_key =
GetRemappedKey(prefs::kLanguageRemapCapsLockKeyTo, *pref_service);
« no previous file with comments | « no previous file | ui/events/ozone/evdev/event_modifiers_evdev.h » ('j') | ui/events/ozone/evdev/keyboard_evdev.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698