Fix CapsLock remapping.

Fix CapsLock remapping.

Emulates the ChromeOS/X11 method of using F16 and Mod3 to
represent the caps lock key before remapping.

BUG=461485
TEST=On device with external keyboard

Committed: https://crrev.com/5fdc45c765de00dd9143879864fa57c7d133e309
Cr-Commit-Position: refs/heads/master@{#318240}

Committed: https://crrev.com/c786931969cce37492bd97c82138a35540b19a3f
Cr-Commit-Position: refs/heads/master@{#318321}

[kpschoedel, 2015-02-25 21:16:29]

kpschoedel@chromium.org changed reviewers:
+ derat@chromium.org, spang@chromium.org

[kpschoedel, 2015-02-25 21:16:29]

+spang for ui/events/ozone/
+derat for event_rewriter.cc

The fact that EF_CAPS_LOCK_DOWN does not mean that CAPS_LOCK is DOWN is bad, and
it should feel bad.

[spang, 2015-02-25 22:03:20]

On 2015/02/25 21:16:29, kpschoedel wrote:
> +spang for ui/events/ozone/
> +derat for event_rewriter.cc
> 
> The fact that EF_CAPS_LOCK_DOWN does not mean that CAPS_LOCK is DOWN is bad,
and
> it should feel bad.

We should transition away from this kind of flag abuse. I think it's ok as a
stopgap but could you add a TODO at least?

[spang, 2015-02-25 22:03:29]

https://codereview.chromium.org/959923002/diff/1/ui/events/ozone/evdev/keyboa...
File ui/events/ozone/evdev/keyboard_evdev.cc (right):

https://codereview.chromium.org/959923002/diff/1/ui/events/ozone/evdev/keyboa...
ui/events/ozone/evdev/keyboard_evdev.cc:122:
modifiers_->UpdateModifier(modifier, down);
Wouldn't it work to just do

// TODO: Do key remapping earlier.
if (modifier == EVDEV_MODIFIER_CAPS_LOCK)
  modifiers_->UpdateModifier(EVDEV_MODIFIER_MOD3, down);

and keep everything else the same?

[Daniel Erat, 2015-02-25 22:13:45]

https://codereview.chromium.org/959923002/diff/1/chrome/browser/chromeos/even...
File chrome/browser/chromeos/events/event_rewriter.cc (right):

https://codereview.chromium.org/959923002/diff/1/chrome/browser/chromeos/even...
chrome/browser/chromeos/events/event_rewriter.cc:643: // XK_ISO_Level3_Shift
with Mod3Mask, not XF86XK_Launch7).
does this comment need to be updated to describe where VKEY_CAPITAL comes from,
or is that what the "XK_ISO_Level3_Shift with Mod3Mask" part refers to?

[kpschoedel, 2015-02-25 23:03:06]

https://codereview.chromium.org/959923002/diff/1/chrome/browser/chromeos/even...
File chrome/browser/chromeos/events/event_rewriter.cc (right):

https://codereview.chromium.org/959923002/diff/1/chrome/browser/chromeos/even...
chrome/browser/chromeos/events/event_rewriter.cc:643: // XK_ISO_Level3_Shift
with Mod3Mask, not XF86XK_Launch7).
On 2015/02/25 22:13:45, Daniel Erat wrote:
> does this comment need to be updated to describe where VKEY_CAPITAL comes
from,
> or is that what the "XK_ISO_Level3_Shift with Mod3Mask" part refers to?

Using spang's suggestion & removing this file from the CL.

https://codereview.chromium.org/959923002/diff/1/ui/events/ozone/evdev/keyboa...
File ui/events/ozone/evdev/keyboard_evdev.cc (right):

https://codereview.chromium.org/959923002/diff/1/ui/events/ozone/evdev/keyboa...
ui/events/ozone/evdev/keyboard_evdev.cc:122:
modifiers_->UpdateModifier(modifier, down);
On 2015/02/25 22:03:28, spang wrote:
> Wouldn't it work to just do
> 
> // TODO: Do key remapping earlier.
> if (modifier == EVDEV_MODIFIER_CAPS_LOCK)
>   modifiers_->UpdateModifier(EVDEV_MODIFIER_MOD3, down);
> 
> and keep everything else the same?

Done.

[spang, 2015-02-25 23:12:19]

thank you lgtm

[kpschoedel, 2015-02-25 23:51:38]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2015-02-26 00:02:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/959923002/20001

[commit-bot: I haz the power, 2015-02-26 00:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-26 00:05:30]

Try jobs failed on following builders:
  ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng...)
  ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[spang, 2015-02-26 01:28:07]

The CQ bit was checked by spang@chromium.org

[spang, 2015-02-26 01:28:12]

The CQ bit was unchecked by spang@chromium.org

[kpschoedel, 2015-02-26 16:02:28]

The CQ bit was checked by kpschoedel@chromium.org

[commit-bot: I haz the power, 2015-02-26 16:03:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/959923002/20001

[commit-bot: I haz the power, 2015-02-26 16:12:34]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-26 16:13:50]

Patchset 2 (id:??) landed as
https://crrev.com/5fdc45c765de00dd9143879864fa57c7d133e309
Cr-Commit-Position: refs/heads/master@{#318240}

[grt (UTC plus 2), 2015-02-26 19:16:40]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/965473002/ by grt@chromium.org.

The reason for reverting is: EventConverterEvdevImplTest.KeyWithLock failing
consistently on Linux ChromiumOS Ozone Tests (1)..

[kpschoedel, 2015-02-26 20:04:40]

The CQ bit was checked by kpschoedel@chromium.org

[kpschoedel, 2015-02-26 20:04:40]

The patchset sent to the CQ was uploaded after l-g-t-m from spang@chromium.org
Link to the patchset: https://codereview.chromium.org/959923002/#ps40001 (title:
"fix unit test")

[commit-bot: I haz the power, 2015-02-26 20:05:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/959923002/40001

[commit-bot: I haz the power, 2015-02-26 21:45:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-26 21:46:50]

Patchset 3 (id:??) landed as
https://crrev.com/c786931969cce37492bd97c82138a35540b19a3f
Cr-Commit-Position: refs/heads/master@{#318321}