components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc - Issue 959913002: Create fluent Builder for DataReductionProxyTestContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

Issue 959913002: Create fluent Builder for DataReductionProxyTestContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sclittle CR comments + 1 unittest cleanup Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/content/browser/data_reduction_proxy_debug_resource_throttle_unittest.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

index 149029e4b63c3005e242a0940044071ed5e911fa..75e40d87f228028f7f8d4de8a363a05cb48e90c4 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_protocol_unittest.cc

@@ -90,14 +90,16 @@ class DataReductionProxyProtocolTest : public testing::Test {

}

void SetUp() override {

- test_context_.reset(new DataReductionProxyTestContext(

- DataReductionProxyParams::kAllowed |

- DataReductionProxyParams::kFallbackAllowed |

- DataReductionProxyParams::kPromoAllowed,

- TestDataReductionProxyParams::HAS_EVERYTHING &

- ~TestDataReductionProxyParams::HAS_DEV_ORIGIN &

- ~TestDataReductionProxyParams::HAS_DEV_FALLBACK_ORIGIN,

- DataReductionProxyTestContext::DEFAULT_TEST_CONTEXT_OPTIONS));

+ test_context_ =

+ DataReductionProxyTestContext::Builder()

+ .WithParamsFlags(DataReductionProxyParams::kAllowed |

+ DataReductionProxyParams::kFallbackAllowed |

+ DataReductionProxyParams::kPromoAllowed)

+ .WithParamsDefinitions(

+ TestDataReductionProxyParams::HAS_EVERYTHING &

+ ~TestDataReductionProxyParams::HAS_DEV_ORIGIN &

+ ~TestDataReductionProxyParams::HAS_DEV_FALLBACK_ORIGIN)

+ .Build();

network_change_notifier_.reset(net::NetworkChangeNotifier::CreateMock());

net::NetworkChangeNotifier::SetTestNotificationsOnly(true);

test_context_->RunUntilIdle();