Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 959883003: [SkSVGDevice] drawBitmap* support (Closed)

Created:
5 years, 10 months ago by f(malita)
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed2, reed1
CC:
reviews_skia.org, shawcroft_google.com
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

[SkSVGDevice] drawBitmap* support Also fix a clip transform issue: clips are tracked in device space, but if applied directly to leaf elements they are also subject to local transforms ("transform='...'"). Instead, apply via <g> wrapper elements. R=reed@google.com,mtklein@google.com Committed: https://skia.googlesource.com/skia/+/827da23c71310408b2854516af5e2a8910bf700e

Patch Set 1 #

Patch Set 2 : win warning fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -18 lines) Patch
M src/svg/SkSVGDevice.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/svg/SkSVGDevice.cpp View 1 7 chunks +87 lines, -18 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
f(malita)
5 years, 10 months ago (2015-02-25 23:31:48 UTC) #1
reed2
lgtm what we really need going forward is some way to "test" the backend end ...
5 years, 10 months ago (2015-02-26 17:43:32 UTC) #3
f(malita)
On 2015/02/26 17:43:32, reed2 wrote: > lgtm > > what we really need going forward ...
5 years, 10 months ago (2015-02-27 01:59:26 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959883003/1
5 years, 10 months ago (2015-02-27 01:59:40 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/2722)
5 years, 10 months ago (2015-02-27 02:06:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959883003/20001
5 years, 9 months ago (2015-02-27 15:32:51 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 15:45:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/827da23c71310408b2854516af5e2a8910bf700e

Powered by Google App Engine
This is Rietveld 408576698