Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 959873003: Add WebScheduler implementation to HTMLViewer (Closed)

Created:
5 years, 10 months ago by DaveMoore
Modified:
5 years, 10 months ago
Reviewers:
Aaron Boodman, jamesr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WebScheduler implementation to HTMLViewer BUG= Committed: https://crrev.com/7995ec80910f1b5fcf6c1a02ecd070bed81cbd8e Cr-Commit-Position: refs/heads/master@{#318125}

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 4

Patch Set 3 : Review nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -1 line) Patch
M mojo/services/html_viewer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.cc View 2 chunks +6 lines, -1 line 0 comments Download
A mojo/services/html_viewer/webscheduler_impl.h View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A mojo/services/html_viewer/webscheduler_impl.cc View 1 2 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
DaveMoore
Cleanup
5 years, 10 months ago (2015-02-25 20:27:02 UTC) #1
DaveMoore
5 years, 10 months ago (2015-02-25 20:27:19 UTC) #3
DaveMoore
5 years, 10 months ago (2015-02-25 20:43:04 UTC) #5
jamesr
lgtm https://codereview.chromium.org/959873003/diff/20001/mojo/services/html_viewer/webscheduler_impl.h File mojo/services/html_viewer/webscheduler_impl.h (right): https://codereview.chromium.org/959873003/diff/20001/mojo/services/html_viewer/webscheduler_impl.h#newcode21 mojo/services/html_viewer/webscheduler_impl.h:21: void postIdleTask(const blink::WebTraceLocation& location, document that these functions ...
5 years, 10 months ago (2015-02-25 20:53:22 UTC) #6
DaveMoore
Review nits
5 years, 10 months ago (2015-02-25 20:57:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959873003/40001
5 years, 10 months ago (2015-02-25 20:59:41 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-25 21:54:10 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 22:44:54 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7995ec80910f1b5fcf6c1a02ecd070bed81cbd8e
Cr-Commit-Position: refs/heads/master@{#318125}

Powered by Google App Engine
This is Rietveld 408576698