Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 959783003: Add scroll restoration type to page state (Closed)

Created:
5 years, 9 months ago by majidvp
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, WRONG-USE-chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add scroll restoration type to page state The scroll restoration type is added to page state and serialized. It is used by blink to control the scroll/scale restoration behaviour for history entries. Its value may be provided by user via web-exposed API. Blink side CL: http://crrev.com/927213004 BUG=444094 Committed: https://crrev.com/bbac25a678deb0148e6f8a553e451a6a6ab1a6ac Cr-Commit-Position: refs/heads/master@{#329632}

Patch Set 1 #

Patch Set 2 : Add tests #

Patch Set 3 : rebase #

Patch Set 4 : Change to should_restore_scroll #

Patch Set 5 : remove added noise #

Patch Set 6 : Use enum for scroll restoration type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -3 lines) Patch
M content/common/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/common/page_state_serialization.h View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M content/common/page_state_serialization.cc View 1 2 3 4 5 5 chunks +13 lines, -3 lines 0 comments Download
M content/common/page_state_serialization_unittest.cc View 1 2 3 4 5 4 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/history_serialization.cc View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
A content/test/data/page_state/serialized_v21.dat View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
majidvp
5 years, 9 months ago (2015-02-26 17:45:05 UTC) #2
tdresser
LGTM, but make sure to get someone more familiar with this area of the code ...
5 years, 9 months ago (2015-02-26 18:21:16 UTC) #3
majidvp
+sievers@ for OWNER's review.
5 years, 9 months ago (2015-03-02 14:39:14 UTC) #5
no sievers
On 2015/03/02 14:39:14, majidvp wrote: > +sievers@ for OWNER's review. looks fine if that is ...
5 years, 9 months ago (2015-03-02 19:53:20 UTC) #7
majidvp
On 2015/03/02 19:53:20, sievers wrote: > On 2015/03/02 14:39:14, majidvp wrote: > > +sievers@ for ...
5 years, 7 months ago (2015-05-07 18:13:04 UTC) #8
Nate Chapin
On 2015/05/07 18:13:04, majidvp wrote: > On 2015/03/02 19:53:20, sievers wrote: > > On 2015/03/02 ...
5 years, 7 months ago (2015-05-07 20:27:55 UTC) #9
majidvp
On 2015/05/07 20:27:55, Nate Chapin wrote: > On 2015/05/07 18:13:04, majidvp wrote: > > On ...
5 years, 7 months ago (2015-05-12 18:02:47 UTC) #10
no sievers
lgtm
5 years, 7 months ago (2015-05-12 18:16:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959783003/100001
5 years, 7 months ago (2015-05-13 13:28:41 UTC) #16
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-13 14:26:20 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 14:27:04 UTC) #18
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/bbac25a678deb0148e6f8a553e451a6a6ab1a6ac
Cr-Commit-Position: refs/heads/master@{#329632}

Powered by Google App Engine
This is Rietveld 408576698