Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 959773005: Share sky::PlatformImpl bettween sky_viewer and SkyShell (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Share sky::PlatformImpl bettween sky_viewer and SkyShell This should let SkyShell load images. R=eseidel@chromium.org BUG=https://github.com/domokit/mojo/issues/52 Committed: https://chromium.googlesource.com/external/mojo/+/ea4e62f626400b626eb5fc3845f5ad007b00671d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -574 lines) Patch
A sky/services/platform/BUILD.gn View 1 chunk +26 lines, -0 lines 0 comments Download
A + sky/services/platform/net_constants.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/services/platform/platform_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + sky/services/platform/platform_impl.cc View 1 chunk +5 lines, -6 lines 0 comments Download
A + sky/services/platform/url_request_types.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/services/platform/url_request_types.cc View 1 chunk +1 line, -1 line 0 comments Download
A + sky/services/platform/weburlloader_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sky/services/platform/weburlloader_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/shell/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M sky/shell/ui/engine.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/shell/ui/engine.cc View 2 chunks +9 lines, -4 lines 0 comments Download
D sky/shell/ui/platform_impl.h View 1 chunk +0 lines, -37 lines 0 comments Download
D sky/shell/ui/platform_impl.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M sky/viewer/BUILD.gn View 2 chunks +1 line, -7 lines 0 comments Download
D sky/viewer/converters/url_request_types.h View 1 chunk +0 lines, -23 lines 0 comments Download
D sky/viewer/converters/url_request_types.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M sky/viewer/document_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
D sky/viewer/platform/net_constants.h View 1 chunk +0 lines, -16 lines 0 comments Download
D sky/viewer/platform/platform_impl.h View 1 chunk +0 lines, -39 lines 0 comments Download
D sky/viewer/platform/platform_impl.cc View 1 chunk +0 lines, -48 lines 0 comments Download
D sky/viewer/platform/weburlloader_impl.h View 1 chunk +0 lines, -52 lines 0 comments Download
D sky/viewer/platform/weburlloader_impl.cc View 1 chunk +0 lines, -195 lines 0 comments Download
M sky/viewer/viewer.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 10 months ago (2015-02-25 22:20:30 UTC) #1
eseidel
lgtm
5 years, 10 months ago (2015-02-25 22:23:33 UTC) #2
abarth-chromium
5 years, 10 months ago (2015-02-25 22:26:57 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ea4e62f626400b626eb5fc3845f5ad007b00671d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698