Issue 959763002: Revert of fAddedToCache doesn't need to be atomic.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 959763002: Revert of fAddedToCache doesn't need to be atomic. (Closed)

Created:
5 years, 10 months ago by mtklein

Modified:
5 years, 10 months ago

Reviewers:
mtklein_C, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of fAddedToCache doesn't need to be atomic. (patchset #1 id:1 of https://codereview.chromium.org/960573002/) Reason for revert: Yes it does. notifyAddedToCache() must be thread-safe. Original issue's description: > fAddedToCache doesn't need to be atomic. > > It's only ever read or set from non-threadsafe methods. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/fbe0edfec4fed2a09e12b049d527d280f16e75b3 TBR=reed@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/61010772e59638ff97acb3200a4ec88aa55037a6

Created: 5 years, 10 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	include/core/SkPixelRef.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	src/core/SkPixelRef.cpp	View		3 chunks	+5 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of fAddedToCache doesn't need to be atomic.

5 years, 10 months ago (2015-02-25 16:26:41 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959763002/1

5 years, 10 months ago (2015-02-25 16:27:33 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-25 16:27:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/61010772e59638ff97acb3200a4ec88aa55037a6