Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: net/spdy/spdy_stream.h

Issue 959743002: Account for HTTP/2 padding in receive windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_stream.h
diff --git a/net/spdy/spdy_stream.h b/net/spdy/spdy_stream.h
index ad916bcf6af3e3db32de364ad86fb5b3dab7a45a..26da667470f07aba95c43542c94f74a74d0676fe 100644
--- a/net/spdy/spdy_stream.h
+++ b/net/spdy/spdy_stream.h
@@ -262,8 +262,8 @@ class NET_EXPORT_PRIVATE SpdyStream {
// If stream flow control is turned off, this must not be called.
void IncreaseRecvWindowSize(int32 delta_window_size);
- // Called by OnDataReceived (which is in turn called by the session)
- // to decrease this stream's receive window size by
+ // Called by OnDataReceived or OnPaddingConsumed (which are in turn called by
+ // the session) to decrease this stream's receive window size by
// |delta_window_size|, which must be at least 1 and must not cause
// this stream's receive window size to go negative.
//
@@ -315,6 +315,10 @@ class NET_EXPORT_PRIVATE SpdyStream {
// the stream is being closed.
void OnDataReceived(scoped_ptr<SpdyBuffer> buffer);
+ // Called by the SpdySession when padding is consumed to allow for the stream
+ // receiving window to be updated.
+ void OnPaddingConsumed(size_t len);
+
// Called by the SpdySession when a frame has been successfully and
// completely written. |frame_size| is the total size of the frame
// in bytes, including framing overhead.

Powered by Google App Engine
This is Rietveld 408576698