Issue 959733002: Port public version macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 959733002: Port public version macros. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach

Modified:
5 years, 10 months ago

Reviewers:
bnoordhuis, Jakob Kummerow

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@3.30

Target Ref:
refs/pending/branch-heads/3.30

Project:
v8

Visibility:
Public.

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -52 lines)			Patch
M	PRESUBMIT.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	include/v8.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	include/v8-version.h	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/version.cc	View	2 chunks	+16 lines, -50 lines	0 comments	Download

Total messages: 4 (1 generated)

Jakob Kummerow

LGTM, but I think the 3.30 branch is dead anyway.

5 years, 10 months ago (2015-02-25 15:43:43 UTC) #3

Michael Achenbach

5 years, 10 months ago (2015-02-26 08:56:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
0128a0a5153cb95947589c1c07bfc98cbc70e0cb.