Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 959733002: Port public version macros. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@3.30
Target Ref:
refs/pending/branch-heads/3.30
Project:
v8
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -52 lines) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M include/v8.h View 1 chunk +1 line, -0 lines 0 comments Download
A include/v8-version.h View 1 chunk +20 lines, -0 lines 0 comments Download
M src/version.cc View 2 chunks +16 lines, -50 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Michael Achenbach
PTAL
5 years, 10 months ago (2015-02-25 15:24:34 UTC) #2
Jakob Kummerow
LGTM, but I think the 3.30 branch is dead anyway.
5 years, 10 months ago (2015-02-25 15:43:43 UTC) #3
Michael Achenbach
5 years, 10 months ago (2015-02-26 08:56:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0128a0a5153cb95947589c1c07bfc98cbc70e0cb.

Powered by Google App Engine
This is Rietveld 408576698