Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 959723002: Revert of Revert of DevTools: do not mute the protocol channel while reattaching. (Closed)

Created:
5 years, 10 months ago by sergeyv
Modified:
5 years, 10 months ago
Reviewers:
dgozman, yurys, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of DevTools: do not mute the protocol channel while reattaching. (patchset #1 id:1 of https://codereview.chromium.org/958573002/) Reason for revert: DevToolsSanityTest.TestReattachAfterCrash doesn't check anything now, and this patch wasn't an origin of the flakiness on OSX 10.6. DevToolsSanityTest.TestReattachAfterCrash was disabled, so I reland original patch. Original issue's description: > Revert of DevTools: do not mute the protocol channel while reattaching. (patchset #1 id:1 of https://codereview.chromium.org/945303002/) > > Reason for revert: > DevToolsSanityTest.TestReattachAfterCrash is flaky on OSX 10.6 after this patch > > Original issue's description: > > DevTools: do not mute the protocol channel while reattaching. > > Otherwise sync notifications are not going through. > > > > BUG=460697 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190745 > > TBR=dgozman@chromium.org,yurys@chromium.org,pfeldman@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=460697, 461616 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190817 TBR=dgozman@chromium.org,yurys@chromium.org,pfeldman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460697, 461616 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M Source/web/WebDevToolsAgentImpl.cpp View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sergeyv
Created Revert of Revert of DevTools: do not mute the protocol channel while reattaching.
5 years, 10 months ago (2015-02-25 14:49:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959723002/1
5 years, 10 months ago (2015-02-25 14:50:15 UTC) #2
yurys
lgtm
5 years, 10 months ago (2015-02-25 14:50:45 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 14:50:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190832

Powered by Google App Engine
This is Rietveld 408576698