DescriptionRevert of Revert of DevTools: do not mute the protocol channel while reattaching. (patchset #1 id:1 of https://codereview.chromium.org/958573002/)
Reason for revert:
DevToolsSanityTest.TestReattachAfterCrash doesn't check anything now, and this patch wasn't an origin of the flakiness on OSX 10.6. DevToolsSanityTest.TestReattachAfterCrash was disabled, so I reland original patch.
Original issue's description:
> Revert of DevTools: do not mute the protocol channel while reattaching. (patchset #1 id:1 of https://codereview.chromium.org/945303002/)
>
> Reason for revert:
> DevToolsSanityTest.TestReattachAfterCrash is flaky on OSX 10.6 after this patch
>
> Original issue's description:
> > DevTools: do not mute the protocol channel while reattaching.
> > Otherwise sync notifications are not going through.
> >
> > BUG=460697
> >
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190745
>
> TBR=dgozman@chromium.org,yurys@chromium.org,pfeldman@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=460697, 461616
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190817
TBR=dgozman@chromium.org,yurys@chromium.org,pfeldman@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460697, 461616
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190832
Patch Set 1 #
Created: 5 years, 10 months ago
(Patch set is too large to download)
Messages
Total messages: 4 (0 generated)
|