PRESUBMIT.py - Issue 959713003: Add public version macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: PRESUBMIT.py

Issue 959713003: Add public version macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py

index 3ae39863e116134563e255524b53765da9d959ac..5b3d58d3ba50d802638bd3adad6573621ebe5877 100644

--- a/PRESUBMIT.py

+++ b/PRESUBMIT.py

@@ -200,8 +200,8 @@ def _CommonChecks(input_api, output_api):

def _SkipTreeCheck(input_api, output_api):

"""Check the env var whether we want to skip tree check.

- Only skip if src/version.cc has been updated."""

- src_version = 'src/version.cc'

+ Only skip if include/v8-version.h has been updated."""

+ src_version = 'include/v8-version.h'

FilterFile = lambda file: file.LocalPath() == src_version

if not input_api.AffectedSourceFiles(

lambda file: file.LocalPath() == src_version):

« no previous file with comments | « no previous file | include/v8.h » ('j') | no next file with comments »