Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: PRESUBMIT.py

Issue 959713003: Add public version macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | include/v8.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 182 matching lines...) Expand 10 before | Expand all | Expand 10 after
193 input_api, output_api)) 193 input_api, output_api))
194 results.extend(_V8PresubmitChecks(input_api, output_api)) 194 results.extend(_V8PresubmitChecks(input_api, output_api))
195 results.extend(_CheckUnwantedDependencies(input_api, output_api)) 195 results.extend(_CheckUnwantedDependencies(input_api, output_api))
196 results.extend( 196 results.extend(
197 _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api)) 197 _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api))
198 return results 198 return results
199 199
200 200
201 def _SkipTreeCheck(input_api, output_api): 201 def _SkipTreeCheck(input_api, output_api):
202 """Check the env var whether we want to skip tree check. 202 """Check the env var whether we want to skip tree check.
203 Only skip if src/version.cc has been updated.""" 203 Only skip if include/v8-version.h has been updated."""
204 src_version = 'src/version.cc' 204 src_version = 'include/v8-version.h'
205 FilterFile = lambda file: file.LocalPath() == src_version 205 FilterFile = lambda file: file.LocalPath() == src_version
206 if not input_api.AffectedSourceFiles( 206 if not input_api.AffectedSourceFiles(
207 lambda file: file.LocalPath() == src_version): 207 lambda file: file.LocalPath() == src_version):
208 return False 208 return False
209 return input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip' 209 return input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip'
210 210
211 211
212 def _CheckChangeLogFlag(input_api, output_api): 212 def _CheckChangeLogFlag(input_api, output_api):
213 """Checks usage of LOG= flag in the commit message.""" 213 """Checks usage of LOG= flag in the commit message."""
214 results = [] 214 results = []
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 'v8_win_rel': set(['defaulttests']), 252 'v8_win_rel': set(['defaulttests']),
253 'v8_win_compile_dbg': set(['defaulttests']), 253 'v8_win_compile_dbg': set(['defaulttests']),
254 'v8_win64_rel': set(['defaulttests']), 254 'v8_win64_rel': set(['defaulttests']),
255 'v8_mac_rel': set(['defaulttests']), 255 'v8_mac_rel': set(['defaulttests']),
256 'v8_linux_arm_rel': set(['defaulttests']), 256 'v8_linux_arm_rel': set(['defaulttests']),
257 'v8_linux_arm64_rel': set(['defaulttests']), 257 'v8_linux_arm64_rel': set(['defaulttests']),
258 'v8_android_arm_compile_rel': set(['defaulttests']), 258 'v8_android_arm_compile_rel': set(['defaulttests']),
259 'v8_linux_chromium_gn_rel': set(['defaulttests']), 259 'v8_linux_chromium_gn_rel': set(['defaulttests']),
260 }, 260 },
261 } 261 }
OLDNEW
« no previous file with comments | « no previous file | include/v8.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698