Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Issue 959713003: Add public version macros. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add public version macros. Side note: tools/v8-info.sh seems to have been broken ever since the move to git. At least it's not more broken now. BUG=v8:3075 LOG=y TEST=./script_test.py Committed: https://crrev.com/9dac60ad2d38ae934ea37a5e90096cce8d950e08 Cr-Commit-Position: refs/heads/master@{#26873}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -316 lines) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download
M include/v8.h View 1 chunk +1 line, -0 lines 0 comments Download
A include/v8-version.h View 1 chunk +20 lines, -0 lines 0 comments Download
M src/version.cc View 2 chunks +14 lines, -24 lines 0 comments Download
M tools/release/common_includes.py View 3 chunks +10 lines, -10 lines 0 comments Download
M tools/release/merge_to_branch.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/release/test_scripts.py View 10 chunks +30 lines, -27 lines 0 comments Download
D tools/test-push-to-trunk.sh View 1 chunk +0 lines, -246 lines 0 comments Download
M tools/v8-info.sh View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Achenbach
PTAL. Copy of https://codereview.chromium.org/955963002/
5 years, 10 months ago (2015-02-25 15:01:42 UTC) #2
Michael Achenbach
Guess we're lacking some gyp and gn changes that also need to be backmerged...
5 years, 10 months ago (2015-02-25 15:27:03 UTC) #3
Jakob Kummerow
lgtm
5 years, 10 months ago (2015-02-25 15:38:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/959713003/1
5 years, 10 months ago (2015-02-26 08:58:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 08:59:21 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 08:59:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9dac60ad2d38ae934ea37a5e90096cce8d950e08
Cr-Commit-Position: refs/heads/master@{#26873}

Powered by Google App Engine
This is Rietveld 408576698